cmd/otk-*: fix all otk external to be wrapped in a "tree" json #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When otk calls externals it expects them to be wrapped inside a "tree" json key for both the inputs and the outputs. This is important to make the schema extensible. However the existing otk externals in this repo do not respect that. This commit fixes it and updates the tests.
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Sep 2, 2024
This is similar to osbuild#827 but this time for the `otk-gen-partition-table` which was forgoten in this other PR :(
mvo5
added a commit
to mvo5/images
that referenced
this pull request
Sep 2, 2024
This is similar to osbuild#827 but this time for the `otk-gen-partition-table` which was forgoten in this other PR :(
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2024
This is similar to #827 but this time for the `otk-gen-partition-table` which was forgoten in this other PR :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When otk calls externals it expects them to be wrapped inside a "tree" json key for both the inputs and the outputs. This is important to make the schema extensible. However the existing otk externals in this repo do not respect that.
This commit fixes it and updates the tests.