blueprint: fix filesystem minsize toml key #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The toml tag for customizations.filesystem.minsize was incorrectly set to size. In osbuild-composer this was already changed to minsize [1]. The blueprint implementation in this repo is used directly in bootc-image-builder, so the tags affect how the config is parsed by that tool. Our blueprint reference for bootc-image-builder also uses `minsize` [2]. Let's finally unify the config everywhere. [1] osbuild/osbuild-composer#3783 [2] https://osbuild.org/docs/user-guide/blueprint-reference/#filesystems
kingsleyzissou
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toml tag for customizations.filesystem.minsize was incorrectly set to size. In osbuild-composer this was already changed to minsize [1]. The blueprint implementation in this repo is used directly in bootc-image-builder, so the tags affect how the config is parsed by that tool.
Our blueprint reference for bootc-image-builder also uses
minsize[2]. Let's finally unify the config everywhere.[1] osbuild/osbuild-composer#3783
[2] https://osbuild.org/docs/user-guide/blueprint-reference/#filesystems