manifest/raw: apply BootFiles #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BootFiles need to be applied on the raw images as well.
ondrejbudai
approved these changes
Mar 14, 2024
bcl
reviewed
Mar 14, 2024
| } | ||
|
|
||
| if fsRootMntName == "" { | ||
| panic("no mount found for the filesystem root") |
There was a problem hiding this comment.
Yea, this was a quick copy and paste to unblock (from raw_ostree), we'll be removing all of these panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BootFiles need to be applied on the raw images as well. See #520, this is blocking Fedora.
This is duplicated code from
manifest/raw_ostree, let's apply it to all images in a followup and properly abstract it out :)