Generate the ALL-MANIFEST for bootc disk images #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never used it in bootc-image-builder.
The bootc-disk image manifest now always contains all pipelines needed to generate all image types. This way we can build any combination of disk images depending on what we need to export without needing to conditionally add or remove pipelines. The Platform no longer needs to be read, since we're generating all of the formats and the architecture depends on the source container. However, the Platform is still required for specifying the boot mode (enabling or disabling BIOS boot). The first return value of the InstantiateManifestFromContainers() function, the artifact, was not used and has been removed now.
achilleas-k
requested review from
ondrejbudai,
cgwalters,
mvo5 and
kingsleyzissou
ondrejbudai
reviewed
Mar 12, 2024
achilleas-k
force-pushed
the
bootc-disk/all-manifest
branch
from
990e432
to
20b398c
Compare
achilleas-k
added a commit
to achilleas-k/bootc-image-builder
that referenced
this pull request
Mar 13, 2024
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Mar 14, 2024
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Mar 14, 2024
github-merge-queue bot
pushed a commit
to osbuild/bootc-image-builder
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bootc-disk image manifest now always contains all pipelines needed to generate all image types. This way we can build any combination of disk images depending on what we need to export without needing to conditionally add or remove pipelines.
The Platform no longer needs to be read, since we're generating all of the formats and the architecture depends on the source container. However, the Platform is still required for specifying the boot mode (enabling or disabling BIOS boot).
The first return value of the InstantiateManifestFromContainers() function, the artifact, was not used and has been removed now.