image: always set filename for bootc raw pipeline #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In BIB, we intend to export multiple images from the same pipeline and this is the expected filename for the raw images. Set it so that it's always disk.raw even when we're building a qcow2 or other image type.
supakeen
approved these changes
Mar 7, 2024
|
The comment (and commit message) is a bit wrong. We're not exporting from the same pipeline but from the same manifest. It's probably fine though. |
cgwalters
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BIB, we intend to export multiple images from the same pipeline and this is the expected filename for the raw images. Set it so that it's always disk.raw even when we're building a qcow2 or other image type.