Simplify GitHub > GitLab trigger workflow #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
force-pushed
the
simplify-workflow
branch
from
64e588d
to
6ffebd4
Compare
Update the comments in the workflow files to explain how the gitlab trigger chain works.
In the Start GitLab CI workflow, instead of writing the PR data to a file and then parsing it, just parse it directly as a here string.
We never used the SKIP_CI logic in this repository. We intend to ake the GitLab workflow a pretty much empty one that's just there to trigger the chain, but we first need to merge this change so it's in main while the PR that changes the trigger workflow runs.
achilleas-k
force-pushed
the
simplify-workflow
branch
from
6ffebd4
to
93a7ee3
Compare
supakeen
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never used the SKIP_CI logic in this repository. We intend to ake the GitLab workflow a pretty much empty one that's just there to trigger the chain, but we first need to merge this change so it's in main while the PR that changes the trigger workflow runs.
A follow-up PR will drop the SKIP_CI upload artifact bits once this is merged.
Recreated after #493 from a branch on the main repository to get the new workflows running.
EDIT: That didn't work either: https://github.com/osbuild/images/actions/runs/8146383205/job/22264762905