From 6ea5d0bb6e7d2f19653af90eb04d16b41b745d14 Mon Sep 17 00:00:00 2001
From: wolfgangroese <wolfgang.roese@orso.co>
Date: Mon, 19 Jun 2023 15:36:33 +0200
Subject: [PATCH] tests further adjusted

---
 .../IntegrationTests/NewsControllerTests.cs        | 14 +++++++++++---
 .../DtoTestData/NewsDtoData.cs                     | 10 ++++------
 2 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/Tests/Orso.Arpa.Api.Tests/IntegrationTests/NewsControllerTests.cs b/Tests/Orso.Arpa.Api.Tests/IntegrationTests/NewsControllerTests.cs
index 2c33f7c3f..e4a9787a4 100644
--- a/Tests/Orso.Arpa.Api.Tests/IntegrationTests/NewsControllerTests.cs
+++ b/Tests/Orso.Arpa.Api.Tests/IntegrationTests/NewsControllerTests.cs
@@ -21,7 +21,11 @@ public class NewsControllerTests : IntegrationTestBase
     {
         [Test, Order(1)]
         public async Task Should_Get_All()
+
         {
+            // Arrange
+            List<NewsDto> expectedDtos = new List<NewsDto> { NewsDtoData.SecondNews };
+
             // Act
             HttpResponseMessage responseMessage = await _authenticatedServer
                 .CreateClient()
@@ -31,14 +35,14 @@ public async Task Should_Get_All()
             // Assert
             _ = responseMessage.StatusCode.Should().Be(HttpStatusCode.OK);
             IEnumerable<NewsDto> result = await DeserializeResponseMessageAsync<IEnumerable<NewsDto>>(responseMessage);
-            _ = result.Should().BeEquivalentTo(NewsDtoData.News, opt => opt.WithStrictOrdering());
+            _ = result.Should().BeEquivalentTo(expectedDtos, opt => opt.WithStrictOrdering());
         }
 
         [Test, Order(2)]
         public async Task Should_Get_ById()
         {
             // Arrange
-            NewsDto expectedDto = NewsDtoData.Performer;
+            NewsDto expectedDto = NewsDtoData.SecondNews;
 
             // Act
             HttpResponseMessage responseMessage = await _authenticatedServer
@@ -60,7 +64,7 @@ public async Task Should_Modify()
             {
                 NewsText = "ErsteNewsModifiziert",
                 Url = "http://orsopolis.com",
-                Show = false,
+                Show = false
             };
 
             var expectedDto = new NewsDto
@@ -69,6 +73,10 @@ public async Task Should_Modify()
                 NewsText = "ErsteNewsModifiziert",
                 Url = "http://orsopolis.com",
                 Show = false,
+                CreatedBy = "anonymous",
+                CreatedAt = FakeDateTime.UtcNow,
+                ModifiedAt = FakeDateTime.UtcNow,
+                ModifiedBy = "Staff Member"
             };
 
             // Act
diff --git a/Tests/Orso.Arpa.Tests.Shared/DtoTestData/NewsDtoData.cs b/Tests/Orso.Arpa.Tests.Shared/DtoTestData/NewsDtoData.cs
index c7a106aa5..f25ef0271 100644
--- a/Tests/Orso.Arpa.Tests.Shared/DtoTestData/NewsDtoData.cs
+++ b/Tests/Orso.Arpa.Tests.Shared/DtoTestData/NewsDtoData.cs
@@ -1,8 +1,6 @@
 using System;
 using System.Collections.Generic;
 using Orso.Arpa.Application.NewsApplication;
-using Orso.Arpa.Domain.Entities;
-using Orso.Arpa.Domain.Enums;
 using Orso.Arpa.Tests.Shared.FakeData;
 
 namespace Orso.Arpa.Tests.Shared.DtoTestData
@@ -15,13 +13,13 @@ public static IList<NewsDto> News
             {
                 return new List<NewsDto>
                 {
-                    Performer,
-                    Staff
+                    FirstNews,
+                    SecondNews
                 };
             }
         }
 
-        public static NewsDto Staff
+        public static NewsDto FirstNews
         {
             get
             {
@@ -37,7 +35,7 @@ public static NewsDto Staff
             }
         }
 
-        public static NewsDto Performer
+        public static NewsDto SecondNews
         {
             get
             {