Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparations for js-ipfs 0.36 #630

Closed
alanshaw opened this issue May 22, 2019 · 7 comments
Closed

preparations for js-ipfs 0.36 #630

alanshaw opened this issue May 22, 2019 · 7 comments

Comments

@alanshaw
Copy link

👋 I upgraded ipfs to 0.36.0-rc.0 and some of the tests failed 😢. Please check out the release issue for info on breaking changes.

@aphelionz
Copy link
Member

Looking at this a bit closer it looks like we need to expand the orbit-db-io module to handle base64 hashes in addition to pb and cbor. Does that sound right, @shamb0t ?

@shamb0t
Copy link
Member

shamb0t commented May 30, 2019

@aphelionz the codecs are still pb and cbor, the base has changed to base32. But yes should be a small fix in orbit-db-io converting the hashes to base58

@aphelionz
Copy link
Member

Ah ok! My bad

@shamb0t
Copy link
Member

shamb0t commented May 31, 2019

Versions 0.34.4 and 0.36.3 appear to give different hashes for the same object. Not sure if I'm missing something. Opened an issue here ipfs/js-ipfs#2141 @alanshaw maybe you can shine some light?

@satazor
Copy link

satazor commented Jun 16, 2019

@shamb0t you seem to have updated orbit-db-io default base to be base58. Is there any other issues preventing us from upgrading?

@shamb0t
Copy link
Member

shamb0t commented Jun 16, 2019

👋 @satazor that's right, ipfs should already be upgraded in orbit-db@0.21.3 so I believe this can be closed

@shamb0t shamb0t closed this as completed Jun 16, 2019
@satazor
Copy link

satazor commented Jun 16, 2019

Awesome @shamb0t 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@aphelionz @alanshaw @satazor @shamb0t and others