Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preparations for js-ipfs 0.29.0 #369

Closed
daviddias opened this issue May 28, 2018 · 6 comments
Closed

preparations for js-ipfs 0.29.0 #369

daviddias opened this issue May 28, 2018 · 6 comments

Comments

@daviddias
Copy link
Member

Similar to orbitdb-archive/ipfs-log#124. Here I was less lucky, some tests failed with always the same error, example bellow:

 6) orbit-db - Automatic Replication (js-ipfs)
       automatic replication exchanges the correct heads:

      Uncaught AssertionError [ERR_ASSERTION]: must be a valid cid
      + expected - actual

      -false
      +true
@haadcode
Copy link
Member

Thanks @diasdavid for keeping us up to date! ❤️

Will try to work the new release into OrbitDB asap. Any ideas what the ^ must be a valid cid comes from? PubSub (as mentioned in orbitdb-archive/ipfs-log#124)?

@mistakia
Copy link
Contributor

mistakia commented May 29, 2018

I'm seeing this error here.

I think it may have to do with js-ipfs-block updating to using class-is. When I updated all instances of js-ipfs-block packages to 0.7.1 the error went away for me.

@haadcode
Copy link
Member

Thanks @kia for looking into this! That may very well be the reason. Would you be willing to make a PR for this in ipfs-log? Feel free to say no and we'll make sure it gets updated and fixed asap.

@mistakia
Copy link
Contributor

It doesn't look like orbit-db or ipfs-log has js-ipfs-block in its dependency tree though.

@mistakia
Copy link
Contributor

oh - I guess the tests do though right?

@daviddias
Copy link
Member Author

My recommendation is to update all deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants