Stream images when performing conversions (#22)

optixsolutions · Oct 30, 2019 · 2a0ddea · 2a0ddea
1 parent c47b641
commit 2a0ddea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/ImageManipulator.php b/src/ImageManipulator.php
@@ -48,17 +48,19 @@ public function manipulate(Media $media, array $conversions, $onlyIfMissing = tr
         foreach ($conversions as $conversion) {
             $path = $media->getPath($conversion);
 
-            if ($onlyIfMissing && $media->filesystem()->exists($path)) {
+            $filesystem = $media->filesystem();
+
+            if ($onlyIfMissing && $filesystem->exists($path)) {
                 continue;
             }
 
             $converter = $this->conversionRegistry->get($conversion);
 
-            $image = $converter(
-                $this->imageManager->make($media->getFullPath())
-            );
+            $image = $converter($this->imageManager->make(
+                $filesystem->readStream($media->getPath())
+            ));
 
-            $media->filesystem()->put($path, $image->stream());
+            $filesystem->put($path, $image->stream());
         }
     }
 }
diff --git a/tests/ImageManipulatorTest.php b/tests/ImageManipulatorTest.php
@@ -40,6 +40,7 @@ public function it_will_apply_registered_conversions()
         $media->mime_type = 'image/png';
 
         $filesystem = Mockery::mock(Filesystem::class);
+        $filesystem->shouldReceive('readStream')->andReturn('stream-data');
         $filesystem->shouldReceive('path')->with($media->getPath())->andReturn('full-path');
 
         // Assert that the converted file is saved...