Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peg simplecov version to 0.8.0.pre #1066

Merged
merged 1 commit into from
Apr 7, 2014
Merged

Peg simplecov version to 0.8.0.pre #1066

merged 1 commit into from
Apr 7, 2014

Conversation

myabc
Copy link
Contributor

@myabc myabc commented Apr 1, 2014

simplecov >= 0.8.1 causes an issue preventing execution of the Test::Unit suite.

@myabc
Peg simplecov version to 0.8.0.pre
5bd8e8c 
simplecov >= 0.8.1 causes an issue preventing execution of the
Test::Unit suite.

Signed-off-by: Alex Coles <alex@alexbcoles.com>
@myabc myabc mentioned this pull request Apr 1, 2014
Merged
@myabc
Copy link
Contributor Author

myabc commented Apr 1, 2014

See also codeclimate/ruby-test-reporter/issues/22

@hschink
Copy link
Contributor

hschink commented Apr 4, 2014

@myabc according to this note on the simplecov's project page one should even force the usage of version 0.7.1. What do you think about it?

@myabc
Copy link
Contributor Author

myabc commented Apr 4, 2014

@hschink Best to ask @tessi, I think (see 49c4506). I'm not sure if we are using any features that are only in Simplecov 0.8.0 and not in Simplecov 0.7.1.

@myabc
Copy link
Contributor Author

myabc commented Apr 4, 2014

Also: simplecov-ruby/simplecov#281

@myabc myabc assigned tessi and unassigned hschink Apr 7, 2014
@tessi
Copy link
Collaborator

tessi commented Apr 7, 2014

i pushed a version with simplecov 0.7.1 and we'll see what travis says. I'd merge when travis is ok with the change

@myabc
Copy link
Contributor Author

myabc commented Apr 7, 2014

@tessi It doesn't look like that many changes: https://github.com/colszowka/simplecov/compare/v0.7.1...v0.8.0.pre?w=1

@tessi
Copy link
Collaborator

tessi commented Apr 7, 2014

right. some of them (e.g. a global ~/.simplecov) seem to be useful. I might just force-push-delete my commit and merge yours ;)

hv4jsal

@tessi tessi closed this Apr 7, 2014
@tessi tessi reopened this Apr 7, 2014
tessi pushed a commit that referenced this pull request Apr 7, 2014
Merge pull request #1066 from opf/fix/peg-simplecov-version
56d1a24 
Peg simplecov version to 0.8.0.pre
@tessi tessi merged commit 56d1a24 into dev Apr 7, 2014
@tessi tessi deleted the fix/peg-simplecov-version branch April 7, 2014 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tessi tessi

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myabc @hschink @tessi