Migrate all specs to the newer expect syntax #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Coles <alex@alexbcoles.com>
This conversion is done by Transpec 1.10.4 with the following command:
transpec
* 1414 conversions
from: obj.should
to: expect(obj).to
* 646 conversions
from: == expected
to: eq(expected)
* 376 conversions
from: obj.stub(:message)
to: allow(obj).to receive(:message)
* 107 conversions
from: obj.should_not
to: expect(obj).not_to
* 70 conversions
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
* 45 conversions
from: =~ [1, 2]
to: match_array([1, 2])
* 27 conversions
from: lambda { }.should
to: expect { }.to
* 13 conversions
from: Klass.any_instance.stub(:message)
to: allow_any_instance_of(Klass).to receive(:message)
* 8 conversions
from: === expected
to: be === expected
* 7 conversions
from: expect { }.not_to raise_error(SpecificErrorClass)
to: expect { }.not_to raise_error
* 6 conversions
from: =~ /pattern/
to: match(/pattern/)
* 2 conversions
from: obj.should_not_receive(:message)
to: expect(obj).not_to receive(:message)
* 1 conversion
from: < expected
to: be < expected
* 1 conversion
from: obj.stub!(:message)
to: allow(obj).to receive(:message)
* 1 conversion
from: stub('something')
to: double('something')
Broken in previous commit 26ade602: RSpec::Mocks.allow_message is a lower-level API method, allowing us to define a stub outside of an ExampleGroup context. Signed-off-by: Alex Coles <alex@alexbcoles.com>
Helper fixed in previous commit e31bec17. Signed-off-by: Alex Coles <alex@alexbcoles.com>
Deprecated negative raise_error expectations were removed by Transpec in previous commit 26ade602: this example was previously masking an ArgumentError. Signed-off-by: Alex Coles <alex@alexbcoles.com>
RSpec should syntax masked an issue with the route_to matcher on a separate line not being called. Signed-off-by: Alex Coles <alex@alexbcoles.com>
Signed-off-by: Alex Coles <alex@alexbcoles.com>
RSpec expect syntax no longer supports this operator matcher. Signed-off-by: Alex Coles <alex@alexbcoles.com>
|
n.b. This PR doesn't cover cukes, but they could be migrated in a similar fashion. |
* remove query params from expectation, since routing specs do not test these. / HT: @hschink Signed-off-by: Alex Coles <alex@alexbcoles.com>
The previous bundle update of all dependencies broke execution of unit tests: I've yet to determine a more specific cause. This partially reverts commit 6ea4ed8. Signed-off-by: Alex Coles <alex@alexbcoles.com>
|
Issue appears to be with simplecov: See PR #1066 for Gemfile fix. |
|
@myabc I'm sorry but this doesn't work with plug-ins. |
|
@hschink OK. Sorry for that. I will revert 4774aeb, so this work can be merged. There is a ticket for converting syntax in plugins: https://www.openproject.org/work_packages/5674 |
This will break specs on installations with plugins. Reverting until popular plugins are also migrated to the new RSpec syntax (see new task: https://www.openproject.org/work_packages/5674) This reverts commit 4774aeb.
| actionpack (>= 3.0) | ||
| activemodel (>= 3.0) |
There was a problem hiding this comment.
Do you know where this new dependency comes from?
There was a problem hiding this comment.
@hschink it's now a dependency of rspec-rails, but it's been part of our stack since moving to Rails 3, as it's also a required dependency of Rails/Active Record.
| @@ -46,9 +46,9 @@ | |||
| describe 'index.xml' do | |||
| describe 'with unknown project_type' do | |||
| it 'raises ActiveRecord::RecordNotFound errors' do | |||
| lambda do | |||
NoMethodError:
undefined method `original_path_set' for nil:NilClass
Failure only occurs with a full plugin configuration.
See rspec/rspec-rails#860
|
@myabc it's still failing on internal CI: This time |
|
@hschink That's good. It means it's now reproducing what I'm seeing locally. I'll take another look. |
With an OpenProject config containing private plugins this spec will
fail with the following Error:
ActionView::Template::Error: undefined method `allow_password_changes?' for nil:NilClass
./app/models/user.rb:377:in `change_password_allowed?'
This failure was most likely previously obscured because
`render_views` was not enabled.
Signed-off-by: Alex Coles <alex@alexbcoles.com>
|
@hschink OK fix posted. |
Signed-off-by: Alex Coles <alex@alexbcoles.com> Conflicts: spec/models/permitted_params_spec.rb spec/models/work_package/work_package_acts_as_journalized_spec.rb spec/models/work_package/work_package_planning_spec.rb
This conversion is done by Transpec 1.10.4 with the following command:
transpec spec/models/permitted_params_spec.rb
* 10 conversions
from: obj.should
to: expect(obj).to
* 10 conversions
from: == expected
to: eq(expected)
* 1 conversion
from: obj.should_receive(:message)
to: expect(obj).to receive(:message)
tessi
pushed a commit
that referenced
this pull request
Apr 8, 2014
Migrate all specs to the newer expect syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our specs are currently a mix of the older should syntax and the newer expect syntax. I wanted the excuse to give Transpec a try – as you can see, it seems to do a good job. I needed to make very a handful of subsequent fixes.
This relates to https://www.openproject.org/work_packages/4044 – and may assist with the upgrade to RSpec 3.