Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "" instead of /tmp #976

Merged

Conversation

perdasilva
Copy link
Contributor

Signed-off-by: perdasilva perdasilva@redhat.com

Description of the change:
Turns out "" is more robust!

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Signed-off-by: perdasilva <perdasilva@redhat.com>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #976 (fffbe63) into master (d42dcfa) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head fffbe63 differs from pull request most recent head 5ca897f. Consider uploading reports for the commit 5ca897f to get more accurate results

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
- Coverage   52.48%   52.47%   -0.02%     
==========================================
  Files         103      103              
  Lines        9240     9240              
==========================================
- Hits         4850     4849       -1     
- Misses       3468     3469       +1     
  Partials      922      922              
Impacted Files Coverage Δ
pkg/registry/query.go 60.41% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42dcfa...5ca897f. Read the comment docs.

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@joelanford
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@perdasilva perdasilva merged commit b080d08 into operator-framework:master Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants