Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore): bump go to 1.18 #971

Merged
merged 1 commit into from
Jun 10, 2022
Merged

(chore): bump go to 1.18 #971

merged 1 commit into from
Jun 10, 2022

Conversation

grokspawn
Copy link
Contributor

Description of the change:
bump go to 1.18

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@grokspawn grokspawn force-pushed the bump_go_1.18 branch 2 times, most recently from c648849 to 1b34d46 Compare June 9, 2022 21:13
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #971 (80e4a13) into master (043db4f) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 80e4a13 differs from pull request most recent head 9c6bc23. Consider uploading reports for the commit 9c6bc23 to get more accurate results

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   52.48%   52.48%           
=======================================
  Files         103      103           
  Lines        9240     9240           
=======================================
  Hits         4850     4850           
  Misses       3468     3468           
  Partials      922      922           
Impacted Files Coverage Δ
pkg/api/registry.pb.go 3.06% <ø> (ø)
pkg/api/registry_grpc.pb.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 043db4f...9c6bc23. Read the comment docs.

Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2022
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some empty files -- see pkg/lib/indexer/index.Dockerfile* -- were included. I suspect they're generated by a local test. Can we drop them, or are they intentional?

@grokspawn

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@timflannagan
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2022
Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, njhale, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0899512 into master Jun 10, 2022
@grokspawn grokspawn deleted the bump_go_1.18 branch June 10, 2022 14:38
@grokspawn grokspawn linked an issue Jul 5, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump to go 1.18
5 participants