-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): bump go to 1.18 #971
Conversation
c648849
to
1b34d46
Compare
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
=======================================
Coverage 52.48% 52.48%
=======================================
Files 103 103
Lines 9240 9240
=======================================
Hits 4850 4850
Misses 3468 3468
Partials 922 922
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like some empty files -- see pkg/lib/indexer/index.Dockerfile*
-- were included. I suspect they're generated by a local test. Can we drop them, or are they intentional?
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn, njhale, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
Description of the change:
bump go to 1.18
Motivation for the change:
Reviewer Checklist
/docs