Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(opm diff): handle cyclic dependency graph #937

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix(opm diff): handle cyclic dependency graph #937

merged 1 commit into from
Mar 24, 2022

Commits on Mar 23, 2022

  1. fix(opm diff): handle cyclic dependency graph 

    While generating a diff from a catalog that has operators that specify dependencies
that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This
was happening because while generating the diff, the command does a breadth-first
search of the dependency graph generated by the operator bundles, but did not keep
a track of the already visited bundles. As a result, when there was a cycle in the
dependency graph, the command was stuck in an infinite loop.

This PR fixes the issue by keeping track of the already visited bundles during the
search, and moving the search forward with only the bundles that haven't been visited
before.

Fixes operator-framework#936

Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
    @anik120
    anik120 committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    45f486d View commit details
    Browse the repository at this point in the history