fix(opm diff): handle cyclic dependency graph #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anik120
force-pushed
the
fix-diff-cyclic-dep
branch
from
140eef0
to
6927af9
Compare
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 52.21% 52.25% +0.04%
==========================================
Files 103 103
Lines 9117 9126 +9
==========================================
+ Hits 4760 4769 +9
Misses 3451 3451
Partials 906 906
Continue to review full report at Codecov.
|
anik120
force-pushed
the
fix-diff-cyclic-dep
branch
from
6927af9
to
a7efb78
Compare
exdx
reviewed
Mar 22, 2022
joelanford
reviewed
Mar 23, 2022
While generating a diff from a catalog that has operators that specify dependencies that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This was happening because while generating the diff, the command does a breadth-first search of the dependency graph generated by the operator bundles, but did not keep a track of the already visited bundles. As a result, when there was a cycle in the dependency graph, the command was stuck in an infinite loop. This PR fixes the issue by keeping track of the already visited bundles during the search, and moving the search forward with only the bundles that haven't been visited before. Fixes operator-framework#936 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
force-pushed
the
fix-diff-cyclic-dep
branch
from
a7efb78
to
45f486d
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
grokspawn
pushed a commit
that referenced
this pull request
Apr 19, 2022
While generating a diff from a catalog that has operators that specify dependencies that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This was happening because while generating the diff, the command does a breadth-first search of the dependency graph generated by the operator bundles, but did not keep a track of the already visited bundles. As a result, when there was a cycle in the dependency graph, the command was stuck in an infinite loop. This PR fixes the issue by keeping track of the already visited bundles during the search, and moving the search forward with only the bundles that haven't been visited before. Fixes #936 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
grokspawn
pushed a commit
that referenced
this pull request
Apr 20, 2022
While generating a diff from a catalog that has operators that specify dependencies that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This was happening because while generating the diff, the command does a breadth-first search of the dependency graph generated by the operator bundles, but did not keep a track of the already visited bundles. As a result, when there was a cycle in the dependency graph, the command was stuck in an infinite loop. This PR fixes the issue by keeping track of the already visited bundles during the search, and moving the search forward with only the bundles that haven't been visited before. Fixes #936 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While generating a diff from a catalog that has operators that specify dependencies
that are cyclic in nature, eg a->b, b->a, the
opm alpha diffcommand hangs. Thiswas happening because while generating the diff, the command does a breadth-first
search of the dependency graph generated by the operator bundles, but did not keep
a track of the already visited bundles. As a result, when there was a cycle in the
dependency graph, the command was stuck in an infinite loop.
This PR fixes the issue by keeping track of the already visited bundles during the
search, and moving the search forward with only the bundles that haven't been visited
before.
Fixes #936
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs