Upgrade github.com/docker/cli to v20.10.12

[jeloba]

Description of the change:

Upgraded github.com/docker/cli to latest release.

Motivation for the change:

The version previously used contained CVE-2021-41092.

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci]

Hi @jeloba. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[timflannagan]

/ok-to-test

[codecov]

Codecov Report

Merging #894 (8673b73) into master (d69d2e4) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #894      +/-   ##
==========================================
+ Coverage   52.07%   52.21%   +0.13%     
==========================================
  Files         103      103              
  Lines        9092     9117      +25     
==========================================
+ Hits         4735     4760      +25     
- Misses       3449     3451       +2     
+ Partials      908      906       -2     

Impacted Files	Coverage Δ
pkg/lib/registry/registry.go	18.39% <0.00%> (-0.36%)	⬇️
pkg/lib/indexer/indexer.go	10.61% <0.00%> (-0.18%)	⬇️
pkg/containertools/runner.go	0.00% <0.00%> (ø)
pkg/sqlite/load.go	46.28% <0.00%> (+0.29%)	⬆️
alpha/declcfg/diff.go	77.96% <0.00%> (+1.04%)	⬆️
pkg/registry/registry_to_model.go	62.33% <0.00%> (+2.61%)	⬆️
pkg/lib/bundle/exporter.go	62.85% <0.00%> (+6.19%)	⬆️
alpha/declcfg/diff_include.go	67.92% <0.00%> (+6.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69d2e4...8673b73. Read the comment docs.

[jeloba]

@timflannagan the data race looks like a questionable use of a global in the docker (CLI) config loader. Would it be acceptable to synchronize use of the config loader here?

operator-registry/pkg/image/containerdregistry/resolver.go

Line 93 in da57f13

cfg, err := config.Load(dir)

[timflannagan]

@jeloba I haven't been super involved with this codebase, so I'm probably not the best person to answer that. I'd guess burning down any races would be acceptable. Maybe @joelanford or @njhale have a better idea?

[jeloba]

I pushed a crude locking solution for loading the docker config. 🤷

[jeloba]

/retest

[jeloba]

@dinhxuanvu @gallettilance what do I need to do to get this tested, reviewed, or merged?

[joelanford]

/ok-to-test
/approve

[timflannagan]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeloba, joelanford, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [joelanford]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment