feat(constraint): Add constraint type validation to bundle validation #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
dinhxuanvu
force-pushed
the
cel-val-3
branch
2 times, most recently
from
7512c57
to
c649224
Compare
anik120
added a commit
to anik120/operator-registry
that referenced
this pull request
Dec 15, 2021
In PR operator-framework#888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders.
5 tasks
anik120
added a commit
to anik120/operator-registry
that referenced
this pull request
Dec 15, 2021
In PR operator-framework#888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
added a commit
to anik120/operator-registry
that referenced
this pull request
Dec 15, 2021
In PR operator-framework#888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
anik120
added a commit
to anik120/operator-registry
that referenced
this pull request
Dec 15, 2021
In PR operator-framework#888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
openshift-merge-robot
pushed a commit
that referenced
this pull request
Dec 15, 2021
In PR #888, there's vendoring of the cel-go package, one of which is named "debug" (github.com/google/cel-go/common/debug). Due to the .gitignore file ignoring all [Dd]bug folders, the vendored package isn't being checked in by git, causing the build to fail. This PR removes the instruction to ignore [Dd]bug/ folders. Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com>
A new type of dependency named constraint (olm.constraint) which uses CEL expression is introduced in OLM. This new type is added to dependencies.json file in the bundle just like gvk and package dependencies. As a result, a new validation for constraint type is added to ensure this type will be validated for bundle dependencies. Signed-off-by: Vu Dinh <vudinh@outlook.com> Vendor the constraints pkg from api repo Signed-off-by: Vu Dinh <vudinh@outlook.com>
dinhxuanvu
force-pushed
the
cel-val-3
branch
from
c649224
to
9a8c7a0
Compare
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 52.06% 52.07% +0.01%
==========================================
Files 103 103
Lines 9072 9092 +20
==========================================
+ Hits 4723 4735 +12
- Misses 3441 3449 +8
Partials 908 908
Continue to review full report at Codecov.
|
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
A new type of dependency named constraint (olm.constraint) which uses
CEL expression is introduced in OLM. This new type is added to
dependencies.json file in the bundle just like gvk and package
dependencies. As a result, a new validation for constraint type
is added to ensure this type will be validated for bundle
dependencies.
Signed-off-by: Vu Dinh vudinh@outlook.com
Motivation for the change:
Reviewer Checklist
/docs