Update opm commands to specifcy if they don't take args #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov Report
@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 50.65% 50.67% +0.01%
==========================================
Files 102 102
Lines 8879 8879
==========================================
+ Hits 4498 4499 +1
+ Misses 3530 3529 -1
Partials 851 851
Continue to review full report at Codecov.
|
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
tylerslaton
force-pushed
the
no-args-validator
branch
from
01f2071
to
d1388ba
Compare
tylerslaton
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
akihikokuroda
pushed a commit
to akihikokuroda/operator-registry
that referenced
this pull request
Sep 30, 2021
…-framework#786) Signed-off-by: Tyler Slaton <tyslaton@redhat.com> Signed-off-by: akihikokuroda <akihikokuroda2020@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Updating the
opmbinary to specify when a command takes arguments or not. This will prevent typos from successfully running should a user accidentally type args into a command that does not accept them.Motivation for the change:
Issue 703
Reviewer Checklist
/docsCloses 703