-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log a warning when loading bundle manifests with multiple documents #708
Log a warning when loading bundle manifests with multiple documents #708
Conversation
Hi @omertuc. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Force-pushed to fix indentation / lint / rebase |
Force pushed again to fix DCO |
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 51.04% 51.08% +0.03%
==========================================
Files 103 103
Lines 9050 9056 +6
==========================================
+ Hits 4620 4626 +6
Misses 3553 3553
Partials 877 877
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments and a question.
decodeFileFS reads only the first YAML document in a manifest and ignores the rest of the documents in that file. This commit makes it so that it will log a warning when more than one document is encountered in a single manifest file. Inspired by this annoying bug: https://gitlab.com/nvidia/kubernetes/gpu-operator/-/merge_requests/254 Signed-off-by: Omer Tuchfeld <otuchfel@redhat.com>
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri, kevinrizza, omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
decodeFileFS reads only the first YAML document in a manifest and
ignores the rest of the documents in that file. This commit makes
it so that it will log a warning when more than one document is
encountered in a single manifest file.
Motivation for the change:
Inspired by this annoying bug: https://gitlab.com/nvidia/kubernetes/gpu-operator/-/merge_requests/254
Reviewer Checklist
/docs