Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: validate unique bundle versions #1417

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Aug 19, 2024

Description of the change:
Validate that bundles within a package use unique semver versions.

Motivation for the change:
This has always been assumed. Now we are explicitly checking.

I verified that the operatorhubio catalog and all of Red Hat's catalogs for OCP 4.15 and 4.16 continue to pass with this new validation.

Are there any other catalogs that should be checked?

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link
Contributor

openshift-ci bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.22%. Comparing base (e787595) to head (0f175eb).
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/api/api_to_model.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
+ Coverage   48.14%   48.22%   +0.07%     
==========================================
  Files         136      136              
  Lines       12780    12805      +25     
==========================================
+ Hits         6153     6175      +22     
- Misses       5593     5595       +2     
- Partials     1034     1035       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c5512c7 into operator-framework:master Aug 21, 2024
12 checks passed
@joelanford joelanford deleted the validate-unique-versions branch August 22, 2024 12:04
joelanford added a commit to joelanford/operator-registry that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants