Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<chore>: go bump #1142

Merged
merged 1 commit into from
Sep 21, 2023
Merged

<chore>: go bump #1142

merged 1 commit into from
Sep 21, 2023

Conversation

grokspawn
Copy link
Contributor

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@grokspawn
<chore>: go bump
94eff17 
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2023
joelanford
joelanford reviewed Sep 21, 2023
View reviewed changes
go.mod
@@ -1,6 +1,6 @@
module github.com/operator-framework/operator-registry

go 1.19
go 1.20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to bump to 1.21?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s 1.28 is still on 1.20, as @varshaprasad96 mentioned in slack (https://kubernetes.slack.com/archives/C0181L6JYQ2/p1695306483677709?thread_ts=1695306384.252939&cid=C0181L6JYQ2) but really I was just bringing api/reg up to sync with o-l-m, which is on 1.20.

@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 70.00% and project coverage change: +0.04% 🎉

Comparison is base (d02b0b6) 53.79% compared to head (94eff17) 53.84%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
+ Coverage   53.79%   53.84%   +0.04%     
==========================================
  Files         108      108              
  Lines       10199    10225      +26     
==========================================
+ Hits         5487     5506      +19     
- Misses       3744     3747       +3     
- Partials      968      972       +4
Files Changed Coverage Δ
pkg/cache/json.go 59.18% <70.00%> (+2.15%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

perdasilva
perdasilva approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [grokspawn,perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2023
@perdasilva
Copy link
Contributor

/hold until we decide if we merge this one or the kube bump PR

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@perdasilva
Copy link
Contributor

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@openshift-merge-robot openshift-merge-robot merged commit eaebcf6 into operator-framework:master Sep 21, 2023
13 checks passed
@grokspawn grokspawn deleted the go-bump branch September 21, 2023 15:25
@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@perdasilva perdasilva perdasilva approved these changes

@theishshah theishshah Awaiting requested review from theishshah

Assignees

@perdasilva perdasilva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grokspawn @perdasilva @joelanford @openshift-merge-robot