Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not fatally exit from serve commands #1016

Merged
merged 1 commit into from
Aug 24, 2022
Merged

do not fatally exit from serve commands #1016

merged 1 commit into from
Aug 24, 2022

Commits on Aug 24, 2022

  1. do not fatally exit from serve commands 

    When we fatally exit directly in the serve functions, we do not give a
chance for the registered cleanup functions to run, resulting in
temporary files being left behind.

This commit ensures that we always cleanly return an error from the
serve function, thus ensuring that defered cleanups always happen.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
    @joelanford
    joelanford committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    852667e View commit details
    Browse the repository at this point in the history