do not fatally exit from serve commands #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fatally exit directly in the serve functions, we do not give a chance for the registered cleanup functions to run, resulting in temporary files being left behind. This commit ensures that we always cleanly return an error from the serve function, thus ensuring that defered cleanups always happen. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
openshift-ci
bot
added
the
approved
Codecov Report
@@ Coverage Diff @@
## master #1016 +/- ##
=======================================
Coverage 52.97% 52.97%
=======================================
Files 105 105
Lines 9606 9606
=======================================
Hits 5089 5089
Misses 3562 3562
Partials 955 955 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, joelanford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Description of the change:
This commit ensures that we always cleanly return an error from the
serve function, thus ensuring that defered cleanups always happen.
Motivation for the change:
When we fatally exit directly in the serve functions, we do not give a
chance for the registered cleanup functions to run, resulting in
temporary files being left behind.
Reviewer Checklist
/docs