From 8a21a0a724c6cdc2cfed555640d25c3e0e1e6066 Mon Sep 17 00:00:00 2001 From: Jordan Keister Date: Mon, 13 May 2024 12:53:25 -0500 Subject: [PATCH] enforce rfc1123 compatibility for olm.package.name Signed-off-by: Jordan Keister --- alpha/declcfg/declcfg_to_model.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/alpha/declcfg/declcfg_to_model.go b/alpha/declcfg/declcfg_to_model.go index 64de27548..2657efb16 100644 --- a/alpha/declcfg/declcfg_to_model.go +++ b/alpha/declcfg/declcfg_to_model.go @@ -5,6 +5,7 @@ import ( "github.com/blang/semver/v4" "k8s.io/apimachinery/pkg/util/sets" + "k8s.io/apimachinery/pkg/util/validation" "github.com/operator-framework/operator-registry/alpha/model" "github.com/operator-framework/operator-registry/alpha/property" @@ -22,6 +23,10 @@ func ConvertToModel(cfg DeclarativeConfig) (model.Model, error) { return nil, fmt.Errorf("duplicate package %q", p.Name) } + if errs := validation.IsDNS1123Label(p.Name); len(errs) > 0 { + return nil, fmt.Errorf("invalid package name %q: %v", p.Name, errs) + } + mpkg := &model.Package{ Name: p.Name, Description: p.Description,