enforce rfc1123 compatibility for olm.package.name

Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
operator-framework · May 13, 2024 · 8a21a0a · 8a21a0a
1 parent 9fdedc2
commit 8a21a0a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/alpha/declcfg/declcfg_to_model.go b/alpha/declcfg/declcfg_to_model.go
@@ -5,6 +5,7 @@ import (
 
 	"github.com/blang/semver/v4"
 	"k8s.io/apimachinery/pkg/util/sets"
+	"k8s.io/apimachinery/pkg/util/validation"
 
 	"github.com/operator-framework/operator-registry/alpha/model"
 	"github.com/operator-framework/operator-registry/alpha/property"
@@ -22,6 +23,10 @@ func ConvertToModel(cfg DeclarativeConfig) (model.Model, error) {
 			return nil, fmt.Errorf("duplicate package %q", p.Name)
 		}
 
+		if errs := validation.IsDNS1123Label(p.Name); len(errs) > 0 {
+			return nil, fmt.Errorf("invalid package name %q: %v", p.Name, errs)
+		}
+
 		mpkg := &model.Package{
 			Name:        p.Name,
 			Description: p.Description,