-
Notifications
You must be signed in to change notification settings - Fork 247
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(opm diff): handle cyclic dependency graph (#937)
While generating a diff from a catalog that has operators that specify dependencies that are cyclic in nature, eg a->b, b->a, the `opm alpha diff` command hangs. This was happening because while generating the diff, the command does a breadth-first search of the dependency graph generated by the operator bundles, but did not keep a track of the already visited bundles. As a result, when there was a cycle in the dependency graph, the command was stuck in an infinite loop. This PR fixes the issue by keeping track of the already visited bundles during the search, and moving the search forward with only the bundles that haven't been visited before. Fixes #936 Signed-off-by: Anik Bhattacharjee <anikbhattacharya93@gmail.com> Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
- Loading branch information
Showing
4 changed files
with
149 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters