Add CRD description check validation #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return append(f(crds.Owned, "owned"), f(crds.Required, "required")...) | ||
| } |
There was a problem hiding this comment.
We also need to add a test for this one in: https://github.com/operator-framework/api/blob/master/pkg/validation/internal/good_practices_test.go
There was a problem hiding this comment.
There was a problem hiding this comment.
feel free to close sorted out. :-)
This adds a check to the good practices validator that ensures all CRDs declared in the bundle have non-empty descriptions. Both owned and required CRDs will be checked. Note that this validates the CRD definition in the CSV, not any field in the CRD itself. Signed-off-by: Ryan King <ryking@redhat.com>
camilamacedo86
approved these changes
Apr 4, 2022
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmrodri, ryantking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to the good practices validator that ensures all CRDs
declared in the bundle have non-empty descriptions. Both owned and
required CRDs will be checked. Note that this validates the CRD
definition in the CSV, not any field in the CRD itself.
Signed-off-by: Ryan King ryking@redhat.com