Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field for flag(s) flown to Flagpole preset #114

Closed
1ec5 opened this issue Jan 18, 2021 · 0 comments · Fixed by #218
Closed

Add field for flag(s) flown to Flagpole preset #114

1ec5 opened this issue Jan 18, 2021 · 0 comments · Fixed by #218

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 18, 2021

osmlab/name-suggestion-index#4745 added flags to the name-suggestion-index and openstreetmap/iD#8305 will incorporate the resulting presets into iD. The Flagpole preset should have a field for identifying the flag of flags that fly from the flagpole. The two most relevant keys are flag:name and flag:wikidata.

At first glance, brand/brand:wikidata would seem like precedent. However, flag:name is always localized into the local language; unlike brand names, a given language would have its own localized name differing from the English name for almost every flag. This makes a flag:name field less amenable to NSI-powered autocomplete. However, the flag:name field would still be worth including in the preset because plenty of flags are not notable enough to have a Wikidata item (for instance, the flag for a company outside that company’s headquarters).

/cc @bhousel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant