Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty node icon has moved to empty areas, leaving empty nodes part of areas without icon. #9157

Closed
danieldegroot2 opened this issue Jun 11, 2022 · 7 comments
Labels
bug A bug - let's fix this! icon An issue involving icons

Comments

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Jun 11, 2022

Standalone nodes still have the empty node icon.

But nodes part of areas use the fallback 'icon'.

image

Also, empty areas themselves inherit the empty node icon.

image

(related to earlier issue);

The version on osm.org just got updated and the new bike parking icon now shows up:

( #9136 (comment) )

@tyrasd
Copy link
Member

tyrasd commented Jun 13, 2022

interesting… it works for me

image

Can you please explain how exactly you managed to trigger the bug?

@tyrasd tyrasd added the waitfor-info Waiting for more info label Jun 13, 2022
@danieldegroot2
Copy link
Contributor Author

danieldegroot2 commented Jun 13, 2022

Browser: Chrome

@danieldegroot2
Copy link
Contributor Author

@tyrasd I just ran into another issue, was about to submit it but saw your reply. Sorry for the multiple edits, but I've changed my top post now to describe the issue correctly.

@danieldegroot2 danieldegroot2 changed the title Empty node icon now missing Empty node icon has moved to empty areas, leaving empty nodes part of areas without icon. Jun 13, 2022
@danieldegroot2
Copy link
Contributor Author

Also, empty ways now look like this (white-on-white):
image

@tyrasd
Copy link
Member

tyrasd commented Jun 14, 2022

I still cannot reproduce the issue. I tried it with chrome using the integrated version of iD (v2.21.0) on osm.org, and it appears to work just fine. 🤔

Also, empty ways now look like this

this is how it is supposed to look like, isn't it?

@danieldegroot2
Copy link
Contributor Author

danieldegroot2 commented Jun 14, 2022

Summary;
image

Expected behaviour: Area should show an empty square, not a point icon. node part of area or way should show a point icon.

this is how it is supposed to look like, isn't it?

Mostly it makes sense, but you should be able to see at least the nodes (black casing). If you want to display an empty line, you could do the same and give it black casing

image

image

@tyrasd tyrasd added bug A bug - let's fix this! icon An issue involving icons and removed waitfor-info Waiting for more info bug A bug - let's fix this! labels Jun 18, 2022
@tyrasd
Copy link
Member

tyrasd commented Jun 18, 2022

Ah, the missing icon is for vertex nodes. Sorry, I somehow didn't get that info in your first post.

This regression was introduced in bd1836f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this! icon An issue involving icons
Projects
None yet
Development

No branches or pull requests

2 participants