Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iD wants to change shop value despite better match in NSI #8426

Closed
matkoniecz opened this issue Mar 27, 2021 · 1 comment · Fixed by #8305
Closed

iD wants to change shop value despite better match in NSI #8426

matkoniecz opened this issue Mar 27, 2021 · 1 comment · Fixed by #8305

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Mar 27, 2021 •
edited
Loading

Yves Rocher can be tagged as shop=beauty or shop=cosmetics and both are valid an in NSI

But iD want to "upgrade" while changing shop type, without a good reason

https://www.openstreetmap.org/edit?editor=id&node=3845799681#map=19/51.05281/16.97383
screen06

From what I see NSI has correctly also shop=cosmetics - see https://github.com/osmlab/name-suggestion-index/blob/ea9d441ffb3e1594fca160910219929b4393eb12/data/brands/shop/cosmetics.json#L390

triggered by https://forum.openstreetmap.org/viewtopic.php?pid=823920#p823920 where local mapper complains about people incorrectly changing shop=cosmetics into shop=beauty due to "upgrade" button in iD
@bhousel
Copy link
Member

bhousel commented Mar 29, 2021

Screen Shot 2021-03-29 at 9 14 29 AM

This is working as correctly with the current code from #8305 deployed at https://ideditor.org/nsi-v5/

@bhousel bhousel mentioned this issue Mar 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Name-suggestion-index v6 openstreetmap/iD
2 participants
@bhousel @matkoniecz