Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Spritezero-cli' dependency issue when trying to install in local env #80

Closed
Ancymonek opened this issue Oct 27, 2022 · 6 comments
Closed
Labels
dev Improvements or additions to development workflow

Comments

@Ancymonek
Copy link
Contributor

Ancymonek commented Oct 27, 2022

Recently added "@beyondtracks/spritezero-cli": "^2.3.1", dependency tries to install mapnik, which seems to doesn't work on Windows. I've spent a lot of time installing dependencies (like C++ and Visual Studio) to make it work but i lost this battle. After deleting @beyondtracks/spritezero-cli": "^2.3.1", from package.json and run npm install it works like a charm.

obraz

PS It works fine in dev container.

@ttomasz
Copy link
Contributor

ttomasz commented Oct 27, 2022

It should probably be in devDependencies but that won't solve it for this issue. Seems like they have a lot of issues with missing binaries https://github.com/mapnik/node-mapnik/issues . Not sure what to do about it since it's needed only for generating sprites which is something that will be done very rarely when icons change.

@ttomasz
Copy link
Contributor

ttomasz commented Oct 27, 2022

We could remove it but then generating sprites will be more annoying 😅

@ttomasz ttomasz added the dev Improvements or additions to development workflow label Oct 27, 2022
@Ancymonek
Copy link
Contributor Author

@ttomasz
Copy link
Contributor

ttomasz commented Oct 29, 2022

maybe we could leverage something like this https://github.com/macteo/spritezero-docker (or create our own simple docker image) but someone would need to test using that in node script in package.json

@ttomasz
Copy link
Contributor

ttomasz commented Oct 29, 2022

or bake the dependency it into .devcontainer since i'm using mostly that and provide instructions if someone wants to install it manually on their system 😅
or try using older version that windows supports 🤷

@starsep
Copy link
Member

starsep commented Feb 5, 2023

It has been moved to devDependencies in 38dafb9

@starsep starsep closed this as completed Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Improvements or additions to development workflow
Projects
None yet
Development

No branches or pull requests

3 participants