Fix attaching encrypted volume on controller nodes #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with iscsiadm and other command tools there is a need to run the command on the host's namespace. If we don't run it like that the command will get stuck in: cryptsetup luksOpen --key-file=- /dev/dm-8 crypt-os-brick+dev+dm-8 And if we manually run the command with debug option (`--debug --verbose`) we'll see that it gets stuck in: # Udev cookie 0xd4d73ad (semid 3) waiting for zero And is unable to continue with the rest: # Udev cookie 0xd4d3938 (semid 3) destroyed # Releasing crypt device /dev/mapper/3600140584b9fc02da024f9c8130ce253 context. # Releasing device-mapper backend. # Closing read only fd for /dev/mapper/3600140584b9fc02da024f9c8130ce253. Command successful. This patch ensure we use `nsenter` to run `cryptsetup`.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, ASBishop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a84af4c
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like with iscsiadm and other command tools there is a need to run the command on the host's namespace.
If we don't run it like that the command will get stuck in:
And if we manually run the command with debug option (
--debug --verbose) we'll see that it gets stuck in:And is unable to continue with the rest:
This patch ensure we use
nsenterto runcryptsetup.