Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run e2e-metal-ipi tests in disconnected mode #15639

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Run e2e-metal-ipi tests in disconnected mode #15639

merged 1 commit into from
Feb 19, 2021

Conversation

andfasano
Copy link
Contributor

This PR enables running the e2e conformance tests in disconnected mode, by reusing the mirror feature introduced in [1] for the required test images. This will allow to expand the set of support conformance tests for the e2e-metal-ipi tests family (ipv4/ipv6/ipv4v6).

[1] openshift/origin#24887

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@stbenjam
Copy link
Member

stbenjam commented Feb 8, 2021

Also: do we really need to mirror the test images for IPv4?

@andfasano
Copy link
Contributor Author

Also: do we really need to mirror the test images for IPv4?

No we don't really need it (see openshift-metal3/dev-scripts#1183 (comment)), that's a way to proceed until #183 will get approved.

@andfasano andfasano changed the title [WIP] Run e2e-metal-ipi tests in disconnected mode Run e2e-metal-ipi tests in disconnected mode Feb 9, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@andfasano andfasano mentioned this pull request Feb 9, 2021
Merged
@andfasano
Copy link
Contributor Author

andfasano commented Feb 9, 2021 •
edited
Loading

/test pj-rehearse

@openshift-ci-robot
Copy link
Contributor

@andfasano: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test app-ci-config-dry
  • /test boskos-config
  • /test boskos-config-generation
  • /test build01-dry
  • /test build02-dry
  • /test ci-operator-config
  • /test ci-operator-config-metadata
  • /test ci-operator-registry
  • /test ci-secret-generator-config
  • /test ci-testgrid-allow-list
  • /test config
  • /test core-dry
  • /test core-valid
  • /test correctly-sharded-config
  • /test deprecate-templates
  • /test generated-config
  • /test generated-dashboards
  • /test ordered-prow-config
  • /test owners
  • /test pj-rehearse
  • /test prow-config
  • /test prow-config-filenames
  • /test prow-config-semantics
  • /test release-config
  • /test release-controller-config
  • /test secret-generator-config-valid
  • /test services-dry
  • /test services-valid
  • /test step-registry-metadata
  • /test step-registry-shellcheck
  • /test vsphere-dry
  • /test pylint
  • /test yamllint

Use /test all to run the following jobs:

  • pull-ci-openshift-release-master-app-ci-config-dry
  • pull-ci-openshift-release-master-boskos-config
  • pull-ci-openshift-release-master-boskos-config-generation
  • pull-ci-openshift-release-master-build01-dry
  • pull-ci-openshift-release-master-build02-dry
  • pull-ci-openshift-release-master-ci-operator-config
  • pull-ci-openshift-release-master-ci-operator-config-metadata
  • pull-ci-openshift-release-master-ci-operator-registry
  • pull-ci-openshift-release-master-ci-secret-generator-config
  • pull-ci-openshift-release-master-config
  • pull-ci-openshift-release-master-core-dry
  • pull-ci-openshift-release-master-core-valid
  • pull-ci-openshift-release-master-correctly-sharded-config
  • pull-ci-openshift-release-master-deprecate-templates
  • pull-ci-openshift-release-master-generated-config
  • pull-ci-openshift-release-master-generated-dashboards
  • pull-ci-openshift-release-master-ordered-prow-config
  • pull-ci-openshift-release-master-owners
  • pull-ci-openshift-release-master-pj-rehearse
  • pull-ci-openshift-release-master-prow-config
  • pull-ci-openshift-release-master-prow-config-filenames
  • pull-ci-openshift-release-master-prow-config-semantics
  • pull-ci-openshift-release-master-release-config
  • pull-ci-openshift-release-master-release-controller-config
  • pull-ci-openshift-release-master-secret-generator-config-valid
  • pull-ci-openshift-release-master-services-dry
  • pull-ci-openshift-release-master-services-valid
  • pull-ci-openshift-release-master-step-registry-metadata
  • pull-ci-openshift-release-master-step-registry-shellcheck
  • pull-ci-openshift-release-master-vsphere-dry
  • pull-ci-openshift-release-yamllint

In response to this:

/test -j-rehearse

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano
Copy link
Contributor Author

/test all

@andfasano
Copy link
Contributor Author

/test pj-rehearse

1 similar comment
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano changed the title Run e2e-metal-ipi tests in disconnected mode [WIP] Run e2e-metal-ipi tests in disconnected mode Feb 12, 2021
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 12, 2021
@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@andfasano andfasano force-pushed the metal-ipi-disconnected branch 4 times, most recently from 182b68c to d90385d Compare February 18, 2021 16:40
@andfasano andfasano changed the title [WIP] Run e2e-metal-ipi tests in disconnected mode Run e2e-metal-ipi tests in disconnected mode Feb 18, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2021
@honza
Copy link
Member

honza commented Feb 18, 2021

/retest

@andfasano
Copy link
Contributor Author

/test pj-rehearse

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 19, 2021

@andfasano: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/assisted-installer-agent/master/e2e-metal-assisted e569b6f4bf6575c6fbda0593236162f483a5f156 link /test pj-rehearse
ci/rehearse/openshift/assisted-installer-agent/release-4.7/e2e-metal-assisted 3fd74b50e673a359bf5e042b29815605a06530e3 link /test pj-rehearse
ci/rehearse/openshift/assisted-installer/release-4.7/e2e-metal-assisted e1a7674067c2e02379424f50f6d6afc0efe8d4f7 link /test pj-rehearse
ci/rehearse/openshift/cluster-api-provider-baremetal/master/e2e-metal-ipi-upgrade d90385d555164ed856dbee5c12d320acb04ab649 link /test pj-rehearse
ci/prow/pj-rehearse d90385d555164ed856dbee5c12d320acb04ab649 link /test pj-rehearse
ci/rehearse/openshift/baremetal-operator/master/e2e-metal-ipi a009e78 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@honza
Copy link
Member

honza commented Feb 19, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 315da73 into openshift:master Feb 19, 2021
@openshift-ci-robot
Copy link
Contributor

@andfasano: Updated the following 2 configmaps:

  • step-registry configmap in namespace ci at cluster api.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
    • key baremetalds-e2e-conf-commands.sh using file ci-operator/step-registry/baremetalds/e2e/conf/baremetalds-e2e-conf-commands.sh
    • key baremetalds-e2e-test-commands.sh using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key baremetalds-devscripts-setup-commands.sh using file ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
    • key baremetalds-e2e-conf-commands.sh using file ci-operator/step-registry/baremetalds/e2e/conf/baremetalds-e2e-conf-commands.sh
    • key baremetalds-e2e-test-commands.sh using file ci-operator/step-registry/baremetalds/e2e/test/baremetalds-e2e-test-commands.sh

In response to this:

This PR enables running the e2e conformance tests in disconnected mode, by reusing the mirror feature introduced in [1] for the required test images. This will allow to expand the set of support conformance tests for the e2e-metal-ipi tests family (ipv4/ipv6/ipv4v6).

[1] openshift/origin#24887

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@ardaguclu ardaguclu ardaguclu left review comments

@honza honza Awaiting requested review from honza

Assignees

@honza honza

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andfasano @stbenjam @openshift-ci-robot @honza @ardaguclu @openshift-merge-robot