Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Various fixes for c9s variant #1561

Merged

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Aug 7, 2024

See individual commit messages.

Our extensions include packages from various CentOS SIGs, so we need the
keys. We don't bake it into the `c9s` variant base compose; this matches
e.g. the official CentOS Stream container and cloud images which don't
bake it by default either.
Follow-up to 15c7bf9 ("tests/replace-rt-kernel: fix and improve"). This
was pointed out during code review in openshift#1506.
In the SCOS path, we do a `dnf repoquery` to find the latest kernel
that's different from our kernel. This query itself will try to download
repodata, so let's make sure we only enable the repos we can and need.
This should fix the test for SCOS on !x86_64.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Contributor

@yasminvalim yasminvalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, yasminvalim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Aug 7, 2024

CI is still down due to #1551.

/override ci/prow/rhcos-9-build-test-qemu
/override ci/prow/scos-9-build-test-qemu
/override ci/prow/rhcos-9-build-test-metal
/override ci/prow/scos-9-build-test-metal

Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos-9-build-test-metal, ci/prow/rhcos-9-build-test-qemu, ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

CI is still down due to #1551.

/override ci/prow/rhcos-9-build-test-qemu
/override ci/prow/scos-9-build-test-qemu
/override ci/prow/rhcos-9-build-test-metal
/override ci/prow/scos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jlebon jlebon changed the title Various fixes for c9s variant NO-JIRA: Various fixes for c9s variant Aug 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link

@jlebon: This pull request explicitly references no jira issue.

In response to this:

See individual commit messages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ac1dd83 into openshift:master Aug 7, 2024
7 checks passed
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants