Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COS-2769: bump version to 4.17 #1511

Merged
merged 4 commits into from
May 24, 2024
Merged

COS-2769: bump version to 4.17 #1511

merged 4 commits into from
May 24, 2024

Conversation

mike-nguyen
Copy link
Member

4.16 branched so bump the version in main development to 4.17.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 21, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 21, 2024 •
edited by openshift-ci bot
Loading

@mike-nguyen: This pull request references COS-2769 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

4.16 branched so bump the version in main development to 4.17.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mike-nguyen
Copy link
Member Author

/hold
until ART plashet gets added to internal repos. Reviews welcomed still.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@openshift-ci openshift-ci bot requested review from dustymabe and travier May 21, 2024 13:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@jlebon
Copy link
Member

jlebon commented May 21, 2024

There are a few more places that need to be updated. Try a git grep 4\\.16.

@mike-nguyen
bump version to 4.17
55abc92 
4.16 branched so bump the version in main development to 4.17.
@mike-nguyen
Copy link
Member Author

mike-nguyen commented May 21, 2024 •
edited
Loading

There are a few more places that need to be updated. Try a git grep 4\\.16.

Thanks there were a lot more! I will update the branching doc with this PR as a reference.

@mike-nguyen
Copy link
Member Author

mike-nguyen commented May 21, 2024 •
edited
Loading

/hold cancel
ART repos are are added and merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@mike-nguyen
Copy link
Member Author

/retest

@jlebon
Copy link
Member

jlebon commented May 21, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8e6ac83 and 2 for PR HEAD 55abc92 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 353d297 and 1 for PR HEAD 55abc92 in total

@jlebon
Copy link
Member

jlebon commented May 21, 2024

rpm-md repo 'rhel-9.4-baseos'; generated: 2024-05-02T07:02:38Z solvables: 0
rpm-md repo 'rhel-9.4-appstream'; generated: 2024-05-02T07:16:36Z solvables: 0

Huh, the repos are empty. Ahh, I think we need openshift/release#52325 at least.

@jlebon jlebon mentioned this pull request May 21, 2024
Merged
@jlebon
Copy link
Member

jlebon commented May 22, 2024

/retest

@mike-nguyen
Copy link
Member Author

there are rhaos packages are old in the ART plashet causing kola test failures

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

+ git clone /go/src/github.com/openshift/os os
Cloning into 'os'...
fatal: detected dubious ownership in repository at '/go/src/github.com/openshift/os/.git'
To add an exception for this directory, call:

	git config --global --add safe.directory /go/src/github.com/openshift/os/.git
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
{"component":"entrypoint","error":"wrapped process failed: exit status 128","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2024-05-22T01:06:47Z"} 
�[36mINFO�[0m[2024-05-22T01:06:49Z] Ran for 2m56s                                
�[31mERRO�[0m[2024-05-22T01:06:49Z] Some steps failed:                           
�[31mERRO�[0m[2024-05-22T01:06:49Z] 
  * could not run steps: step validate failed: test "validate" failed: could not watch pod: the pod ci-op-7tttzwgt/validate failed after 52s (failed containers: test): ContainerFailed one or more containers exited

Container test exited with code 128, reason Error

@jlebon
Copy link
Member

jlebon commented May 22, 2024

Do you have a ticket already for the rebuilds necessary? We could also temporarily denylist it.

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

Added another commit for that one!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@mike-nguyen
Copy link
Member Author

Do you have a ticket already for the rebuilds necessary? We could also temporarily denylist it.

Also seeing this in the prow/validate job which I've never seen before. Did something change or is something more strict than before?

Added another commit for that one!

@haircommander helped us by building conmon and cri-o with the correct brew tags. We are still waiting for conmon-rs which is usually built by @jnovy

@jlebon jlebon force-pushed the 417_bump_version_manifest branch from 29c2172 to 4685bf4 Compare May 22, 2024 17:54
@jlebon
Copy link
Member

jlebon commented May 22, 2024

/retest

@jlebon jlebon force-pushed the 417_bump_version_manifest branch from 4685bf4 to 4e631c6 Compare May 22, 2024 21:01
@mike-nguyen
Copy link
Member Author

The cri-o rebuild is blocked on RHEL-35883. We may need to skip the test for now.

@jlebon
ci/prow-entrypoint: tell git repo under /src is safe
630d3f3 
That directory is part of the image and so not owned by us. Likely the
base image used for the src container was updated recently to include
newer git.
@jlebon
denylist: add ext.config.version.rhaos-pkgs-match-openshift
030051c 
The cri-o rebuild for 4.17 is blocked on some buildroot issues. Let's
denylist it for now to unblock setting up the 4.17 stream.
@jlebon jlebon force-pushed the 417_bump_version_manifest branch from 4e631c6 to 030051c Compare May 23, 2024 00:50
travier
travier approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@travier
Copy link
Member

travier commented May 23, 2024 •
edited
Loading 

Running test: iso-offline-install.bios
FAIL: iso-offline-install.bios (10m0.002s)
    timed out after 10m0s
Running test: iso-offline-install.mpath.bios
FAIL: iso-offline-install.mpath.bios (10m0.004s)
    timed out after 10m0s
Running test: iso-offline-install-fromram.4k.uefi
FAIL: iso-offline-install-fromram.4k.uefi (10m0.001s)
    timed out after 10m0s
Running test: miniso-install.bios
FAIL: miniso-install.bios (10m0.002s)
    timed out after 10m0s
Running test: miniso-install.nm.bios
FAIL: miniso-install.nm.bios (10m0.007s)
    timed out after 10m0s
Running test: miniso-install.4k.uefi
FAIL: miniso-install.4k.uefi (10m0s)
    timed out after 10m0s
Running test: miniso-install.4k.nm.uefi
FAIL: miniso-install.4k.nm.uefi (10m0.001s)
    timed out after 10m0s
Running test: pxe-offline-install.bios
FAIL: pxe-offline-install.bios (10m0s)
    timed out after 10m0s
Running test: pxe-offline-install.4k.uefi
FAIL: pxe-offline-install.4k.uefi (10m0.002s)
    timed out after 10m0s
Running test: pxe-online-install.bios
FAIL: pxe-online-install.bios (10m0.005s)
    timed out after 10m0s
Running test: pxe-online-install.4k.uefi
FAIL: pxe-online-install.4k.uefi (10m0.008s)
    timed out after 10m0s
Error: harness: test suite failed

Hum, why is SCOS running the UEFI tests? 🤔

Edit: Nevermind, it's EFI only, not Secure Boot.

@travier
Copy link
Member

travier commented May 23, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@travier
Copy link
Member

travier commented May 23, 2024

/retest

1 similar comment
@jlebon
Copy link
Member

jlebon commented May 23, 2024

/retest

@jlebon
c9s: pin selinux-policy-38.1.36-1.el9
455ea2a 
The latest selinux-policy breaks ISO tests:
openshift#1514

Pin to the previous working version for now.

To do this, introduce a new `overrides-c9s.yaml` manifest that we can
use going forward when we need to pin to older versions.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
@jlebon
Copy link
Member

jlebon commented May 23, 2024

Updated this now to pin selinux-policy due to #1514.

@jlebon
Copy link
Member

jlebon commented May 23, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@jlebon
Copy link
Member

jlebon commented May 23, 2024 via email

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2024

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mike-nguyen
Copy link
Member Author

/lgtm jonathan's changes

@jlebon
Copy link
Member

jlebon commented May 24, 2024

And Mike's changes
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlebon, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jlebon,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9ea3765 into openshift:master May 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@dustymabe dustymabe Awaiting requested review from dustymabe

Assignees

@jlebon jlebon

@travier travier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mike-nguyen @openshift-ci-robot @jlebon @travier