COS-2692: Prep patches for base c9s rework #1446
Conversation
openshift-merge-robot
added
the
needs-rebase
jlebon
force-pushed
the
pr/c9s-split-prep
branch
from
ec808e8
to
34eebee
Compare
openshift-merge-robot
removed
the
needs-rebase
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
jlebon
force-pushed
the
pr/c9s-split-prep
branch
from
34eebee
to
c843a76
Compare
openshift-merge-robot
removed
the
needs-rebase
jlebon
changed the title
|
Rebased! This one isn't blocked on anything. |
openshift-ci-robot
added
the
jira/valid-reference
|
@jlebon: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
I think it's confusing when a single postprocessing item actually does multiple disparate things. Let's try to split them up to make it clearer. While we're here, make the indentation consistent. This patch should have no functional effect. Best viewed with whitespace changes ignored.
jlebon
force-pushed
the
pr/c9s-split-prep
branch
from
c843a76
to
9297cb8
Compare
jlebon
changed the title
|
@jlebon: This pull request references COS-2692 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jlebon: This pull request references COS-2692 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Mostly LGTM. Small nits. Maybe we could use another Jira card than https://issues.redhat.com//browse/COS-2692 or update the scope to clarify things? Thanks! |
|
Overall, I don't see a reason to block this from being merged as the nits are minor and can be addressed in a follow-up PR. /lgtm Feel free un unhold as needed. |
openshift-ci
bot
added
the
do-not-merge/hold
As prep for openshift#799, let's better split the postprocessing steps that are related to OCP from those that have tighter binding to RHEL proper. This should have no visible effect.
We were pulling this in transitively, but we do depend on it in postprocessing steps (for semanage). Let's make it explicit.
Just get at the initramfs using a glob instead of trying to parse the BLS. This will work regardless of how the BLS entry is named but assumes that there is only one BLS entry (which should always be the case for these tests).
This is part of openshift#1445. Those tests are all actually testing OCP components. In the new model, they should be run against an OCP layered image instead. Add a tag on them so that we'll be able to run them separately.
It's in all the development streams we care about now so just simplify the manifests. No functional change.
jlebon
force-pushed
the
pr/c9s-split-prep
branch
from
9297cb8
to
0abce5c
Compare
Do you mean having a separate JIRA card for just these prep patches? |
|
@jlebon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Yes, but we can also rewind the card back to in progress if needed so not a big deal. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlebon, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
This is split out of #1445. See individual commits for details.