Skip to content

Commit

Permalink
test direct registry.ci access from e2e
Browse files Browse the repository at this point in the history
  • Loading branch information
gabemontero committed May 14, 2021
1 parent 2f931f9 commit 8b9cd39
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions test/extended/builds/s2i_root.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ package builds
import (
"context"
"fmt"
"github.com/openshift/origin/test/extended/util/image"

g "github.com/onsi/ginkgo"
o "github.com/onsi/gomega"

Expand Down Expand Up @@ -37,7 +35,7 @@ var _ = g.Describe("[sig-builds][Feature:Builds] s2i build with a root user imag
Before(oc)
defer After(oc)

firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", image.LocationFor("registry.ci.openshift.org/ocp/4.7:test-build-roots2i"))
firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", "registry.ci.openshift.org/ocp/4.7:test-build-roots2i")
err := oc.Run("new-app").Args(firstArgString, "--name", "nodejsfail").Execute()
o.Expect(err).NotTo(o.HaveOccurred())

Expand Down Expand Up @@ -114,7 +112,7 @@ var _ = g.Describe("[sig-builds][Feature:Builds] s2i build with a root user imag
roleBinding, err = oc.AdminKubeClient().RbacV1().RoleBindings(oc.Namespace()).Create(context.Background(), roleBinding, metav1.CreateOptions{})
o.Expect(err).NotTo(o.HaveOccurred())

firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", image.LocationFor("registry.ci.openshift.org/ocp/4.7:test-build-roots2i"))
firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", "registry.ci.openshift.org/ocp/4.7:test-build-roots2i")
err = oc.Run("new-build").Args(firstArgString, "--name", "nodejspass").Execute()
o.Expect(err).NotTo(o.HaveOccurred())

Expand Down

0 comments on commit 8b9cd39

Please sign in to comment.