Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop referencing machine-os-content #457

Closed
cgwalters opened this issue Oct 5, 2022 · 7 comments
Closed

stop referencing machine-os-content #457

cgwalters opened this issue Oct 5, 2022 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@cgwalters
Copy link
Member

AIUI current OKD is using machine-os-content as a way to find "the default OS image" - it's making it be a new format image.

I guess actually we could just do that for OCP/RHCOS too, i.e. do a hard cutover and just ship rhel-coreos-8 as a retagging. I'm not opposed to that. But it feels better to make a "clean cut" and have a new image in the new format, and crucially define a better way to find "the default OS image". Which could just be another new tag...like default-operating-system or something.

Anyways the bootstrap phase currently does

MACHINE_CONFIG_OSCONTENT=$(image_for machine-os-content)

and this will eventually break if we do openshift/machine-config-operator#3364

@LorbusChris
Copy link
Member

The fix for this is included in openshift/installer#6443, particularly openshift/installer@55bbb10

@LorbusChris
Copy link
Member

@cgwalters not sure you're aware, we just got this from our latest OKD/SCOS CI release try:

operator "driver-toolkit" contained an invalid image-references file: no input image tag named "machine-os-content"

@LorbusChris
Copy link
Member

Ah, that's openshift/driver-toolkit#102

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2023
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 8, 2023
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this as completed Mar 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2023

@openshift-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants