-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for optional provisioning networks on Baremetal platforms #632
Add support for optional provisioning networks on Baremetal platforms #632
Conversation
92605a9
to
e9a585b
Compare
e9a585b
to
33bb2d6
Compare
install/0000_30_machine-api-operator_04_metal3provisioning.crd.yaml
Outdated
Show resolved
Hide resolved
33bb2d6
to
04bc0be
Compare
04bc0be
to
78f0cf3
Compare
/test e2e-metal-ipi |
/test e2e-aws |
/test e2e-azure-operator |
/test e2e-aws-scaleup-rhel7 |
/test e2e-azure |
/test e2e-gcp |
/test e2e-gcp-operator |
install/0000_30_machine-api-operator_04_metal3provisioning.crd.yaml
Outdated
Show resolved
Hide resolved
From my side this looks good, I haven't tested it together with my PR yet, and I left one question about the enum. Let's just make sure we don't merge until e2e-metal-ipi passes and the normal happy path still works. That will be failing until we get OVN fixed: https://bugzilla.redhat.com/show_bug.cgi?id=1860710 /lgtm |
If the MAO team could approve and let us remove the hold when we're ready, that would be great. |
1b4fb3c
to
7d57ec7
Compare
In addition to supporting fully managed provisioning networks with the option of having external DHCP servers, baremetal installations should also be able to support cases where a dedicated provisioning network does not exist. Details regarding the updates to the provisioning CR to accomodate the above feature can be found in [1]. Also, removing support for the ConfigMap as way to pass provisioning configuration to the MAO for baremetal installs. [1] - https://github.com/openshift/enhancements/blob/master/enhancements/baremetal/baremetal-provisioning-optional.md
7d57ec7
to
0c2655a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/test e2e-metal-ipi |
1 similar comment
/test e2e-metal-ipi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
e2e-metal-ipi is not a blocking job, but we need it to pass. Please remove the hold once e2e-metal-ipi passes. CI is currently flaky, but unrelated to this PR. |
/test e2e-metal-ipi |
ack, thanks for the update @stbenjam |
/test e2e-aws-operator |
/test e2e-metal-ipi |
1 similar comment
/test e2e-metal-ipi |
/test e2e-aws-upgrade |
/test e2e-metal-ipi |
4 similar comments
/test e2e-metal-ipi |
/test e2e-metal-ipi |
/test e2e-metal-ipi |
/test e2e-metal-ipi |
/hold cancel |
In addition to supporting fully managed provisioning networks with the
option of having external DHCP servers, baremetal installations should
also be able to support cases where a dedicated provisioning network
does not exist.
Details regarding the updates to the provisioning CR to accomodate the
above feature can be found in [1].
Also, removing support for the ConfigMap as way to pass provisioning
configuration to the MAO for baremetal installs.
[1] - https://github.com/openshift/enhancements/blob/master/enhancements/baremetal/baremetal-provisioning-optional.md