Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libvirt: Add Terraform variables for memory/CPU, bump master to 4GiB #785

Merged
merged 1 commit into from
Dec 5, 2018
Merged

libvirt: Add Terraform variables for memory/CPU, bump master to 4GiB #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions data/data/libvirt/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ resource "libvirt_domain" "master" {

name = "${var.tectonic_cluster_name}-master-${count.index}"

memory = "3072"
vcpu = "2"
memory = "${var.libvirt_master_memory}"
vcpu = "${var.libvirt_master_vcpu}"

coreos_ignition = "${libvirt_ignition.master.id}"

Expand Down
16 changes: 16 additions & 0 deletions data/data/libvirt/variables-libvirt.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,19 @@ variable "tectonic_libvirt_master_ips" {
type = "list"
description = "the list of desired master ips. Must match tectonic_master_count"
}

# It's definitely recommended to bump this if you can.
variable "libvirt_master_memory" {
type = "string"
description = "RAM in MiB allocated to masters"
default = "4096"
}

# At some point this one is likely to default to the number
# of physical cores you have. See also
# https://pagure.io/standard-test-roles/pull-request/223
variable "libvirt_master_vcpu" {
type = "string"
description = "CPUs allocated to masters"
default = "2"
}