Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data/aws: use nlbs instead of elbs #594

Merged
merged 4 commits into from
Nov 2, 2018
Merged

data/aws: use nlbs instead of elbs #594

merged 4 commits into from
Nov 2, 2018

Commits on Nov 1, 2018

  1. data/aws/route53: remove unused variables

    These variables and outputs aren't used anywhere and can be removed.
    crawford committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    68e4c27 View commit details
    Browse the repository at this point in the history
  2. data/aws: bump aws provider

    The existing version would sometimes panic when creating NLBs and was
    also missing a few options specific to NLBs. There are probably many
    other fixes and improvements that come with the newer provider.
    crawford committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    ac5aeed View commit details
    Browse the repository at this point in the history
  3. vendor: bump github.com/openshift/hive

    This gives the installer the ability to tear down NLBs.
    crawford committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    8823176 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2018

  1. data/aws: use nlbs instead of elbs

    We've noticed an elevated rate of installation failures recently. The
    root cause appears to be 50-90 seconds of latency added to traffic going
    through the internal ELB on port 49500. This was causing Ignition's
    connections to timeout, resulting in the machines never provisioning.
    
    AWS's NLBs don't seem to have this high latency, so we've decided to
    move over to them instead. With the move to NLBs, we also get the
    ability to add individual health checks for each port instead of just a
    single health check for each load balancer. Also, NLBs are cheaper.
    
    This commit drops support for ingress and the console. Since the console
    and router aren't currently configured correctly, nobody should notice
    that this is gone. It was easier to drop support in this commit rather
    than continue to try to plumb through the existing implementation
    knowing that it was going to have to change in the future. Once the
    router has a strategy for ingress, we'll re-add this functionality using
    the new NLBs.
    
    This also drop support for the `<cluster-name>-k8s` DNS entry. We aren't
    aware of any consumers and it was going to be tedious to keep this
    working.
    crawford committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    16dfbb3 View commit details
    Browse the repository at this point in the history