Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/openshift-install: Add a 'version' subcommand #390

Merged
merged 2 commits into from
Oct 2, 2018

Conversation

wking
Copy link
Member

@wking wking commented Oct 2, 2018

And calculate its value based on the most recent Git tag (relative to HEAD). This makes it easy for callers to report the version they're using when reporting issues (or successes :).

Also start up a changelog, so occasional users can get a quick summary of important changes between the current version and whichever one they used most recently.

If the above two changes sound appealing, I think we want to start cutting regular releases (weekly? Every other week? After each sprint?) and start funneling users towards released versions.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2018
And calculate its value based on the most recent Git tag (relative to
HEAD).  This makes it easy for callers to report the version they're
using when reporting issues (or successes :).
This project has been evolving rapidly, which makes it hard for
occasional users to keep up.  By cutting releases and documenting new
features, deprecations, etc., we can make it easier for users to get
back up to speed.  Cutting releases also reduces our maintenance
burden by focusing users on the weekly (or whatever) release instead
of "wherever master was when I cloned".
@crawford
Copy link
Contributor

crawford commented Oct 2, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Oct 2, 2018

Once this lands I'll drop a tag, push some binaries up to GitHub, and send an email :).

@wking
Copy link
Member Author

wking commented Oct 2, 2018

The e2e aws error was:

error: .status.conditions accessor error: Failure is of the type string, expected map[string]interface{}
error deploy/router did not come up
error: .status.conditions accessor error: Failure is of the type string, expected map[string]interface{}
timeout waiting for router to be available
2018/10/02 17:10:35 Container test in pod e2e-aws failed, exit code 1, reason Error

@wking
Copy link
Member Author

wking commented Oct 2, 2018

error: .status.conditions accessor error: Failure is of the type string, expected map[string]interface{}

@smarterclayton suspects the wait command. I'll look into that, but until then:

/retest

@crawford
Copy link
Contributor

crawford commented Oct 2, 2018

@wking Can we get #375 in before the tag?

@wking
Copy link
Member Author

wking commented Oct 2, 2018

@wking Can we get #375 in before the tag?

Sure, I'll give it another pass now.

@openshift-merge-robot openshift-merge-robot merged commit 41077a9 into openshift:master Oct 2, 2018
@smarterclayton
Copy link
Contributor

smarterclayton commented Oct 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants