-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/openshift-install: Add a 'version' subcommand #390
Conversation
And calculate its value based on the most recent Git tag (relative to HEAD). This makes it easy for callers to report the version they're using when reporting issues (or successes :).
This project has been evolving rapidly, which makes it hard for occasional users to keep up. By cutting releases and documenting new features, deprecations, etc., we can make it easier for users to get back up to speed. Cutting releases also reduces our maintenance burden by focusing users on the weekly (or whatever) release instead of "wherever master was when I cloned".
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once this lands I'll drop a tag, push some binaries up to GitHub, and send an email :). |
The e2e aws error was:
|
@smarterclayton suspects the wait command. I'll look into that, but until then: /retest |
It’s a bug in wait, an error is returned by the watch channel and we
misinterpret it. I don’t know what the error is yet.
On Oct 2, 2018, at 1:22 PM, W. Trevor King <notifications@github.com> wrote:
error: .status.conditions accessor error: Failure is of the type
string, expected map[string]interface{}
error deploy/router did not come up
@smarterclayton <https://github.com/smarterclayton> suspects the wait
command
<#330 (comment)>.
I'll look into that, but until then:
/retest
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#390 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_p8bGI9gsskupQDkba9WpWqWrKeg2ks5ug6DKgaJpZM4XDZEp>
.
|
And calculate its value based on the most recent Git tag (relative to
HEAD
). This makes it easy for callers to report the version they're using when reporting issues (or successes :).Also start up a changelog, so occasional users can get a quick summary of important changes between the current version and whichever one they used most recently.
If the above two changes sound appealing, I think we want to start cutting regular releases (weekly? Every other week? After each sprint?) and start funneling users towards released versions.