Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-23406: Enable AllNamespaces install mode #188

Conversation

anirudhAgniRedhat
Copy link
Contributor

@anirudhAgniRedhat anirudhAgniRedhat commented Jun 5, 2024

Adding support for 'All Namespace' mode on install time.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 5, 2024
@openshift-ci-robot
Copy link

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-23406, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and stlaz June 5, 2024 14:46
@arkadeepsen
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 6, 2024
@openshift-ci-robot
Copy link

@arkadeepsen: This pull request references Jira Issue OCPBUGS-23406, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@swghosh
Copy link
Member

swghosh commented Jun 6, 2024

/retitle OCPBUGS-23406: Enable AllNamespaces install mode
/lgtm

@openshift-ci openshift-ci bot changed the title OCPBUGS-23406: Support for 'All Namespace' mode OCPBUGS-23406: Enable AllNamespaces install mode Jun 6, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
@swghosh
Copy link
Member

swghosh commented Jun 6, 2024

/cherrypick cert-manager-1.14

@openshift-cherrypick-robot

@swghosh: once the present PR merges, I will cherry-pick it on top of cert-manager-1.14 in a new PR and assign it to you.

In response to this:

/cherrypick cert-manager-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swghosh
Copy link
Member

swghosh commented Jun 6, 2024

/cc @TrilokGeer
Please review/approve, thanks!

@openshift-ci openshift-ci bot requested a review from TrilokGeer June 6, 2024 10:27
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lable qe-approved

@@ -735,7 +735,7 @@ spec:
type: SingleNamespace
Copy link
Member

@lunarwhite lunarwhite Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to change the SingleNamespace to false?

Like:

  installModes:
  - supported: true
    type: OwnNamespace
  - supported: false
    type: SingleNamespace
  - supported: false
    type: MultiNamespace
  - supported: true
    type: AllNamespaces

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we currently support this option then there is a chance that some customer may use this option (installed using CLI method).

We need to give some notice to the customers before deprecating any options currently supported.

@swghosh
Copy link
Member

swghosh commented Jun 25, 2024

/test fips-image-scan

Copy link
Contributor

openshift-ci bot commented Jun 25, 2024

@anirudhAgniRedhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/fips-image-scan b570552 link true /test fips-image-scan

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@subhtk
Copy link

subhtk commented Jul 11, 2024

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 11, 2024
@TrilokGeer
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anirudhAgniRedhat, swghosh, TrilokGeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2024
@swghosh
Copy link
Member

swghosh commented Jul 15, 2024

/test all

@swghosh
Copy link
Member

swghosh commented Jul 15, 2024

@lunarwhite Not sure why but the qe-approved label seems missing despite yours adding it in the past.

@anirudhAgniRedhat
Copy link
Contributor Author

/test fips-image-scan

Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

@anirudhAgniRedhat: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test ci-index-cert-manager-operator-bundle
  • /test e2e-operator
  • /test fips-image-scan-cert-manager
  • /test fips-image-scan-operator
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

Use /test all to run all jobs.

In response to this:

/test fips-image-scan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swghosh
Copy link
Member

swghosh commented Jul 15, 2024

/cc @davemulford
For px-approved label

@openshift-ci openshift-ci bot requested a review from davemulford July 15, 2024 14:49
@Senthamilarasu-STA
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 15, 2024
@lunarwhite
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 16, 2024
@openshift-ci-robot
Copy link

@anirudhAgniRedhat: This pull request references Jira Issue OCPBUGS-23406, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yuewu@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Adding support for 'All Namespace' mode on install time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 9cf15f1 into openshift:master Jul 16, 2024
10 checks passed
@openshift-ci-robot
Copy link

@anirudhAgniRedhat: Jira Issue OCPBUGS-23406: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23406 has been moved to the MODIFIED state.

In response to this:

Adding support for 'All Namespace' mode on install time.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@swghosh: new pull request created: #193

In response to this:

/cherrypick cert-manager-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants