Build FROM ubi8

[yselkowitz]

The build-quota test runs the findmnt command in its assemble script.
While the full ubi8 includes util-linux, ubi8-minimal does not.

Not sure how this slipped through testing of #7 but it was noticed via openshift/release#18939.

/cc @gabemontero @alicerum

[openshift-ci]

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: gabemontero, alicerum.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

The build-quota test runs the findmnt command in its assemble script.
While the full ubi8 includes util-linux, ubi8-minimal does not.

Not sure how this slipped through testing of #7 but it was noticed via openshift/release#18939.

/cc @gabemontero @alicerum

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gabemontero]

/approve

saw this in the image build failure @yselkowitz :

 STEP 4: RUN microdnf install --nodocs util-linux && microdnf clean all
/bin/sh: microdnf: command not found
error: build error: error building at STEP "RUN microdnf install --nodocs util-linux && microdnf clean all": error while running runtime: exit status 127

[gabemontero]

prow is still broke wrt this repo and the OWNERS file

@bparees is on vacation this week .... hopefully @adambkaplan has permissions to approve

/assign @adambkaplan

[openshift-ci]

@gabemontero: GitHub didn't allow me to assign the following users: adambkaplan.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

prow is still broke wrt this repo and the OWNERS file

@bparees is on vacation this week .... hopefully @adambkaplan has permissions to approve

/assign @adambkaplan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yselkowitz]

Is the test replacing the FROM line? That's the only explanation for not being able to find microdnf. The other alternative is to use the full ubi8, but that would be an overkill for this one package.

[gabemontero]

Is the test replacing the FROM line? That's the only explanation for not being able to find microdnf. The other alternative is to use the full ubi8, but that would be an overkill for this one package.

Yeah that is what going on.

From the image build log: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_build-test-images/9/pull-ci-openshift-build-test-images-master-images/1400194169711890432#1:build-log.txt%3A26

The configuration that makes that happen: https://github.com/openshift/release/blob/master/ci-operator/config/openshift/build-test-images/openshift-build-test-images-master.yaml#L1-L19

Process description at https://docs.ci.openshift.org/docs/architecture/images/

I suspect you would know better than me from your UBI8 efforts last year, but I thought the CI base/builder images were ubi8 based.

[yselkowitz]

Oh, I see, when I proposed moving these images (first to docker.io/busybox, then) to ubi8-minimal, they were still being built manually. At the same time, you went ahead and included this in the upstream CI build framework, which resulted in the builds actually inheriting -- indirectly via cli -- ubi8 (full) which already includes util-linux. (Not sure why cli was picked over e.g. base though.) That would explain why this didn't show up on x86_64.

Given that, either the release configuration should be changed to (iiuc) origin/ubi-minimal:8, or these FROMs should be changed to ubi8 (full) to match what's currently in CI. Let me know which way you want to go.

[yselkowitz]

I went ahead and just changed these to FROM ubi8 to match the current state of CI. Let me know if you decide otherwise.

[gabemontero]

I went ahead and just changed these to FROM ubi8 to match the current state of CI. Let me know if you decide otherwise.

Yeah that is the path of least resistance. I'm fine with tgoing with ubi8 at this point.

I'm not even sure there is a ubi-minimal equivalent for base/builder that we can specify. We'd have to reach out to the test platform guys to see if it even exists, what it would take to add if it does not, etc.

For what we are talking about here, not worth the effort, I'm assuming when multi arch versions of this are built, if you are not using the openshift/release and openshift/ci-config and CI infra for it, working off of ubi8 is OK.

Ultimately, when those images are ready, per the process discussed in https://github.com/openshift/origin/tree/master/test/extended/util/image, you all will need to reach out to Clayton or Maciej to do the oc image mirror .. invocations that get all the multi arch versions of the image defined in https://github.com/openshift/origin/blob/master/test/extended/util/image/zz_generated.txt mirrored up to quay.io/openshift/community-e2e-images ... including our 2 build test images here.

oc image mirror claims support for manifest list of a multi-architecture images.

And yes, I believe you captured all the moving parts etc. in #9 (comment)

/lgtm

[openshift-ci]

@gabemontero: changing LGTM is restricted to collaborators

In response to this:

I went ahead and just changed these to FROM ubi8 to match the current state of CI. Let me know if you decide otherwise.

Yeah that is the path of least resistance. I'm fine with tgoing with ubi8 at this point.

I'm not even sure there is a ubi-minimal equivalent for base/builder that we can specify. We'd have to reach out to the test platform guys to see if it even exists, what it would take to add if it does not, etc.

For what we are talking about here, not worth the effort, I'm assuming when multi arch versions of this are built, if you are not using the openshift/release and openshift/ci-config and CI infra for it, working off of ubi8 is OK.

Ultimately, when those images are ready, per the process discussed in https://github.com/openshift/origin/tree/master/test/extended/util/image, you all will need to reach out to Clayton or Maciej to do the oc image mirror .. invocations that get all the multi arch versions of the image defined in https://github.com/openshift/origin/blob/master/test/extended/util/image/zz_generated.txt mirrored up to quay.io/openshift/community-e2e-images ... including our 2 build test images here.

oc image mirror claims support for manifest list of a multi-architecture images.

And yes, I believe you captured all the moving parts etc. in #9 (comment)

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[adambkaplan]

/lgtm

[openshift-ci]

@adambkaplan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yselkowitz]

/assign @bparees

[bparees]

/approve

[yselkowitz]

ping?

[gabemontero]

yeah the prow for this repo is still messed up some my

/lgtm

is ignored (though I'll try again just in case)

@adambkaplan was looking into this, but don't know the status of that

short term, we may need him or @bparees to green button this

[openshift-ci]

@gabemontero: changing LGTM is restricted to collaborators

In response to this:

yeah the prow for this repo is still messed up some my

/lgtm

is ignored (though I'll try again just in case)

@adambkaplan was looking into this, but don't know the status of that

short term, we may need him or @bparees to green button this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gabemontero]

ah it works now !!!

[gabemontero]

well ... it didn't explicitly reject it .... still waiting on the label ....

[gabemontero]

nevermind ... git is slow ... now see the I"m not a collaborator message

so either @adambkaplan or @bparees would need to green button short term, unless @adambkaplan know the status of the prow confg here