use registry.access.redhat.com/ubi8-minimal for multi-arch support #7

yselkowitz · 2021-03-24T14:22:31Z

Unfortunately, quay.io/quay/busybox is single-arch.

openshift-ci-robot · 2021-03-24T14:22:32Z

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: gabemontero.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Unfortunately, quay.io/quay/busybox is single-arch.

/cc @gabemontero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yselkowitz · 2021-03-24T14:23:26Z

/cc @gabemontero

openshift-ci-robot · 2021-03-24T14:23:27Z

@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: gabemontero.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @gabemontero

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-03-24T14:41:21Z

@yselkowitz I'd rather pull down the docker.io busybox, docker tag it, and push it to quay.io/redhat-developer to avoid docker.io throttling

@sbose78 can help us with creating the landing spot in quay.io/redhat-developer

@bparees @adambkaplan FYI

yselkowitz · 2021-03-24T14:44:32Z

How often are you building this that their rate limiting would be an issue?

gabemontero · 2021-03-24T14:52:12Z

How often are you building this that their rate limiting would be an issue?

even if this is a special case and does not get rebuilt often, throttling has been enough of a pain point I don't want this getting caught up in some sort of "docker.io" scan or something ... call it "good PR"

I'll ping @sbose78 this afternoon after all my meetings if he dies not see this mention in the interim

yselkowitz · 2021-03-24T15:01:36Z

could we (feasibly) switch these to e.g. ubi8-minimal instead?

gabemontero · 2021-03-24T15:03:33Z

could we (feasibly) switch these to e.g. ubi8-minimal instead?

I'm willing to try that yes. It would involve creating the image and then modifying openshift/origin e2e's and running them against a personal cluster to confirm it works.

gabemontero · 2021-03-24T15:04:37Z

Well, to say I'm willing, I mean I'm willing for someone to try it :-)

It would minimally be next week before I could get to it

yselkowitz · 2021-03-25T00:02:49Z

Multi-arch images for testing, with docker.io/busybox:

quay.io/multi-arch/test-build-roots2i:latest
quay.io/multi-arch/test-build-simple2i:latest

With ubi8-minimal:

quay.io/multi-arch/test-build-roots2i:ubi8
quay.io/multi-arch/test-build-simple2i:ubi8

yselkowitz · 2021-03-25T00:14:29Z

As a possible alternative, do we own this: quay.io/openshifttest/busybox:multiarch

sbose78 · 2021-03-25T01:26:24Z

I can help!

gabemontero · 2021-03-26T13:26:59Z

@yselkowitz just to be sure, when you say "multi arch image", you mean you can use quay.io/multi-arch/test-build-roots2i:latest etc. on x86, s390x, ppc64le, etc. and the registry will give you the right arch version, correct?

Assuming so, the process here is as follows:

You very well may have already done this, but the hits under the test/extended from one's https://github.com/openshift/origin clone are, where one would change from quay.io/redhat-developer to quay.io/multi-arch:

gmontero ~/go/src/github.com/openshift/origin/test/extended  (image-eco-e2e-mirror-nono)$ find . -name "*" -exec grep -s -H roots2i {} \;
./util/image/image.go:		"registry.ci.openshift.org/ocp/4.7:test-build-roots2i": -1,
./util/image/zz_generated.txt:registry.ci.openshift.org/ocp/4.7:test-build-roots2i quay.io/openshift/community-e2e-images:e2e-registry-ci-openshift-org-ocp-4-7-test-build-roots2i-tG08qb6aSmDhxBBy
./builds/s2i_root.go:		firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", image.LocationFor("registry.ci.openshift.org/ocp/4.7:test-build-roots2i"))
./builds/s2i_root.go:		firstArgString := fmt.Sprintf("%s~https://github.com/sclorg/nodejs-ex", image.LocationFor("registry.ci.openshift.org/ocp/4.7:test-build-roots2i"))
gmontero ~/go/src/github.com/openshift/origin/test/extended  (image-eco-e2e-mirror-nono)$ find . -name "*" -exec grep -s -H simples2i {} \;
./testdata/templates/templateinstance_readiness.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:              "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:              "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:          "name":"quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/bindata.go:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/bindata.go:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/build-timing/test-s2i-build.json:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/test-s2i-no-outputname.json:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/test-build-cluster-config.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-build-cluster-config.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-auth-build.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-build-proxy.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-build-proxy.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-s2i-build-quota.json:          "name":"quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/statusfail-pushtoregistry.yaml:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/statusfail-failedassemble.yaml:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-s2i-build.json:          "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/valuefrom/failed-sti-build-value-from-config.yaml:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/valuefrom/successful-sti-build-value-from-config.yaml:        name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/build-postcommit/sti.yaml:          name: quay.io/redhat-developer/test-build-simples2i:latest
./testdata/builds/test-build-revision.json:              "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/test-nosrc-build.json:              "name": "quay.io/redhat-developer/test-build-simples2i:latest"
./testdata/builds/statusfail-postcommithook.yaml:        name: quay.io/redhat-developer/test-build-simples2i:latest
gmontero ~/go/src/github.com/openshift/origin/test/extended  (image-eco-e2e-mirror-nono)$

you then make clean / make build to get a new openshift-tests binary. Then with your KUBECONFIG set to whatever cluster you've provisioned, you run

./openshift-tests run openshift/build to verify the build e2e suite, and
./openshift-tests run openshift/templates to verify that one usage in the template e2e suite.

Assuming things work, we merge this, and someone starts on the openshift/origin PR for those above hits.

the util image hits are fun. That is all part of Clayton's initiative to make e2e's fully "disconnected" where are all images are accessed from mirrors set up in CI.

The process for all that is documented at https://github.com/openshift/origin/tree/master/test/extended/util/image

Ultimately, you need to work with Clayton directly to get him to push a version of these images to registry.ci.openshift.org/ocp

gabemontero · 2021-03-31T16:14:20Z

I've also opened https://issues.redhat.com/browse/BUILD-250 to track getting this done by someone on the build api team if we do not get to this in "less official" fashion so to speak

gabemontero · 2021-05-11T21:30:32Z

So per openshift/origin#26149 (comment) @yselkowitz
I'd rather go with with FROM registry.access.redhat.com/ubi8-minimal:latest if it is functional.

I'm lending a quick assist to @alicerum and trying out "quay.io/multi-arch/test-build-roots2i:ubi8" on its own now.

I'll report back with results. Assuming things are good, let's switch to ubi8-minimal in this PR and merge it. That will facilitate the BUILD-250 work she is doing.

We can consider ubi8-micro at a later date.

gabemontero · 2021-05-11T21:34:20Z

Or if you'd rather we craft our own PR @yselkowitz to replace what you have here, we can do that too. Thanks.

gabemontero · 2021-05-11T22:51:23Z

thanks @yselkowitz

/retitle use registry.access.redhat.com/ubi8-minimal for multi-arch support

gabemontero · 2021-05-11T22:57:22Z

fyi

passed: (45.7s) 2021-05-11T22:54:39 "[sig-builds][Feature:Builds] s2i build with a root user image should create a root build and pass with a privileged SCC [Skipped:Disconnected] [Suite:openshift/conformance/parallel]"

when I tried the multi-arch image locally

gabemontero · 2021-05-11T23:32:49Z

also passed in my test PR

and given the only minor diff between roots2i and simples2i @yselkowitz @alicerum @adambkaplan I think we can merge this

/lgtm
/approve

openshift-ci · 2021-05-11T23:32:51Z

@gabemontero: changing LGTM is restricted to collaborators

In response to this:

also passed in my test PR

and given the only minor diff between roots2i and simples2i @yselkowitz @alicerum @adambkaplan I think we can merge this

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-05-11T23:57:05Z

@gabemontero: changing LGTM is restricted to collaborators

ok @bparees or @adambkaplan will have to merge this

adambkaplan

/lgtm

openshift-ci · 2021-05-12T13:05:52Z

@adambkaplan: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2021-05-12T13:09:14Z

fyi @gabemontero you are also listed as an approver in the OWNERS file, and should be able to approve/lgtm

adambkaplan · 2021-05-12T13:55:40Z

yep - spoke with dptp team, will be setting that up today.

bparees · 2021-05-12T13:56:16Z

seems like the prow config for this repo is not correct.

bparees · 2021-05-12T13:56:21Z

/lgtm

bparees · 2021-05-12T13:57:16Z

@adambkaplan since this repo impacts e2e tests for the org(right?), merges to this repo should require e2e tests to pass.

adambkaplan · 2021-05-12T14:12:47Z

Correct - we should have e2e-* and e2e-*-build

adambkaplan · 2021-05-12T16:13:28Z

CI fixes for this repo: openshift/release#18523

gabemontero · 2021-05-14T14:19:08Z

Correct - we should have e2e-* and e2e-*-build

Per #7 (comment) I ran build e2e using the manually built image @yselkowitz pushed to quay.io/multiarch

gabemontero · 2021-05-14T17:39:20Z

also the way the imagestream tagging and mirroring works these changes won't get picked up until we change openshift/origin to pick them up

the roots2i tests works off of registry.ci.openshift.org/ocp/4.7:test-build-roots2i and its mapping to the associated mirrored image from quay.io/openshift/community-e2e-images

This PR and openshift/release#18523 ultimately update registry.ci.openshift.org/ocp/4.8:test-build-roots2i

It will be a 2 step process to change the e2e in https://github.com/openshift/origin/pull/26149/files to work off registry.ci.openshift.org/ocp/4.8:test-build-roots2i and a new mirrored mapping to quay.io/openshift/community-e2e-images

So we merge openshift/release#18523 and then this one. The validate things in openshift/origin#26149 without disrupting other PRs or periodics, as we have not changed registry.ci.openshift.org/ocp/4.7:test-build-roots2i and its mapping to the associated mirrored image from quay.io/openshift/community-e2e-images

(I'm re-learning the complicated https://github.com/openshift/origin/tree/master/test/extended/util/image process and now have (re)established some level of understanding)

gabemontero · 2021-05-14T18:04:53Z

OK openshift/release#18523 has merged.

I think we need to close and reopen this to pick up the CI changes. Will try other stuff first.

The rest below is another attempt to explain our use of https://github.com/openshift/origin/tree/master/test/extended/util/image in relation to the (current at least) lack of need to run the e2e's. Though they can catch unexpected refs to the test images, so I am not advocating removing its use with this repo.

To reiterate what I mentioned in #7 (comment), changes to this repo on its own are not going to affect e2e-aws or e2e-aws-builds on its own, as the openshift/origin tests are currently constructed, since our tests use the 4.7 images, and master branch now points to 4.8.

Moving forward, if the image ref in openshift/origin is aligned with whatever release master branch is pointing to, then the effect will still not immediate, if we follow the prior convention of mapping registry.ci.openshift.org/ocp/4.8:test-build* to images in quay.io/openshift/community-e2e-images, where we need CI admins to push to quay.io/openshift/community-e2e-images

We only need these tests to run if we ever have direct registry.ci.openshift.org/ocp/4.8:test-build* refs in our tests. Though if we do, that will possibly break down when running in disconnected (at least I think)

gabemontero · 2021-05-14T18:05:01Z

/approve

openshift-ci · 2021-05-14T18:05:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabemontero · 2021-05-14T18:05:25Z

/refresh

gabemontero · 2021-05-14T18:07:22Z

OK have the tide indicator now.

gabemontero · 2021-05-14T20:20:15Z

So after openshift/release#18523 merged we got

registry.ci.openshift.org/ocp/4.8 test-build-simples2i bd5bc84df5ba 2 hours ago 392 MB

I'll check it periodically between now and Monday to make sure that gets updated based on this PR merging.

Assuming it does, the story will continue in openshift/origin#26149 where we update the e2e's and some someone from https://github.com/openshift/origin/blob/master/test/extended/util/image/OWNERS to mirror to quay.io/openshift/community-e2e-images:TAG

Ultimately, per the "https://github.com/openshift/origin/blob/master/test/extended/util/image/README.md process" for lack of a better term, someone from https://github.com/openshift/origin/blob/master/test/extended/util/image/OWNERS will have to mirror the multi arch versions of these images to quay.io/openshift/community-e2e-images:TAG

gabemontero · 2021-05-14T21:40:51Z

registry.ci update as a result of this PR occurred:

registry.ci.openshift.org/ocp/4.8 test-build-simples2i 535d5b6dc170 About an hour ago 392 MB

gabemontero mentioned this pull request May 11, 2021

BUILD-250 pull in multi-arch friendly version of roots2i and simples2i, add simples2i to mirroring test infra openshift/origin#26149

Merged

Use ubi8-minimal for multi-arch support

2a3ff83

yselkowitz force-pushed the master branch from c876b1f to 2a3ff83 Compare May 11, 2021 22:23

openshift-ci bot changed the title ~~Use docker.io/busybox for multi-arch support~~ use registry.access.redhat.com/ubi8-minimal for multi-arch support May 11, 2021

adambkaplan approved these changes May 12, 2021

View reviewed changes

openshift-ci bot assigned bparees May 12, 2021

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2021

openshift-merge-robot merged commit 8dc6fb3 into openshift:master May 14, 2021

yselkowitz mentioned this pull request Jun 2, 2021

Build FROM ubi8 #9

Merged

use registry.access.redhat.com/ubi8-minimal for multi-arch support #7

use registry.access.redhat.com/ubi8-minimal for multi-arch support #7

Conversation

yselkowitz commented Mar 24, 2021

openshift-ci-robot commented Mar 24, 2021

yselkowitz commented Mar 24, 2021

openshift-ci-robot commented Mar 24, 2021

gabemontero commented Mar 24, 2021

yselkowitz commented Mar 24, 2021

gabemontero commented Mar 24, 2021

yselkowitz commented Mar 24, 2021

gabemontero commented Mar 24, 2021

gabemontero commented Mar 24, 2021

yselkowitz commented Mar 25, 2021

yselkowitz commented Mar 25, 2021

sbose78 commented Mar 25, 2021

gabemontero commented Mar 26, 2021

gabemontero commented Mar 31, 2021

gabemontero commented May 11, 2021 • edited by openshift-ci bot Loading

gabemontero commented May 11, 2021

gabemontero commented May 11, 2021

gabemontero commented May 11, 2021

gabemontero commented May 11, 2021

openshift-ci bot commented May 11, 2021

gabemontero commented May 11, 2021

adambkaplan left a comment

Choose a reason for hiding this comment

openshift-ci bot commented May 12, 2021

adambkaplan commented May 12, 2021

adambkaplan commented May 12, 2021

bparees commented May 12, 2021

bparees commented May 12, 2021

bparees commented May 12, 2021

adambkaplan commented May 12, 2021

adambkaplan commented May 12, 2021

gabemontero commented May 14, 2021

gabemontero commented May 14, 2021 • edited Loading

gabemontero commented May 14, 2021

gabemontero commented May 14, 2021

openshift-ci bot commented May 14, 2021

gabemontero commented May 14, 2021

gabemontero commented May 14, 2021

gabemontero commented May 14, 2021

gabemontero commented May 14, 2021

gabemontero commented May 11, 2021 •

edited by openshift-ci bot

Loading

gabemontero commented May 14, 2021 •

edited

Loading