Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM-7117 | chore: update metamodel version in sdk to v0.060 #939

Merged

Conversation

davidleerh
Copy link
Contributor

@davidleerh davidleerh commented Apr 5, 2024

Due to data type introduced below never used in the api model ("[]Integer"):
https://github.com/openshift-online/ocm-api-model/pull/921
[]integer

the metamodel would generate an error when generating files for the SDK (via the make generate command).

output/clustersmgmt/v1/load_balancer_quota_values_client.go:162:12: expected type, found '.'
output/clustersmgmt/v1/load_balancer_quota_values_client.go:191:59: expected type, found '.'
output/clustersmgmt/v1/load_balancer_quota_values_client.go:194:6: expected declaration, found '}'
E: Can't format generated sources: exit status 2

Fix introduced in version metamodel v0.060, thanks to @mnecas
openshift-online/ocm-api-metamodel#203

Copy link
Collaborator

@ciaranRoche ciaranRoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ciaranRoche ciaranRoche merged commit f6691b3 into openshift-online:main Apr 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants