[NodeJS18 Upgrade] Add AL2023 Docker Images Selection by BuildDocker lib #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
requested review from
gaiksaya and
rishabh6788
as code owners
This was referenced Sep 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
=========================================
Coverage 87.25% 87.25%
Complexity 28 28
=========================================
Files 79 79
Lines 204 204
Branches 11 11
=========================================
Hits 178 178
Misses 19 19
Partials 7 7 |
gaiksaya
requested changes
Sep 6, 2023
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
gaiksaya
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[NodeJS18 Upgrade] Add AL2023 Docker Images Selection by BuildDocker lib
Issues Resolved
opensearch-project/opensearch-build#1563
opensearch-project/opensearch-build#3743
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.