Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility chart with Almalinux8 and remove CentOS8 since already deprecated #6637

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Mar 8, 2024

Description

Tweak compatibility chart with Almalinux8 and remove CentOS8 since already deprecated

Issues Resolved

Closes opensearch-project/opensearch-build#4573

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter
Copy link
Contributor

hdhalter commented Mar 8, 2024

Thanks, @peterzhuamazon ! Should we close this PR? #4980

@peterzhuamazon
Copy link
Member Author

Thanks, @peterzhuamazon ! Should we close this PR? #4980

Hi @hdhalter, closed old one and will update that once CentOS7 properly deprecated.

@hdhalter
Copy link
Contributor

@peterzhuamazon - Will this be released with 2.13 or should it be backported to 2.12?

@peterzhuamazon
Copy link
Member Author

@peterzhuamazon - Will this be released with 2.13 or should it be backported to 2.12?

This can go with 2.13 and do not need to backport to 2.12 or before.

@hdhalter hdhalter added v2.13.0 release-notes PR: Include this PR in the automated release notes 4 - Doc review PR: Doc review in progress and removed enhancement New feature or request labels Mar 11, 2024
@Naarcha-AWS Naarcha-AWS added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 4 - Doc review PR: Doc review in progress labels Mar 12, 2024
@hdhalter
Copy link
Contributor

@Naarcha-AWS , @peterzhuamazon - Can we merge this into main?

@peterzhuamazon peterzhuamazon marked this pull request as draft March 13, 2024 18:54
@hdhalter hdhalter added On hold and removed 6 - Done but waiting to merge PR: The work is done and ready to merge labels Mar 13, 2024
@Naarcha-AWS
Copy link
Collaborator

@peterzhuamazon: Any update on the status of this one?

@hdhalter hdhalter changed the title Tweak compatibility chart with Almalinux8 and remove CentOS8 since already deprecated Update compatibility chart with Almalinux8 and remove CentOS8 since already deprecated Mar 20, 2024
@hdhalter hdhalter removed the v2.13.0 label Mar 25, 2024
@hdhalter
Copy link
Contributor

@Naarcha-AWS - This will not make 2.13 as per Peter. I removed the label.

@hdhalter hdhalter removed the release-notes PR: Include this PR in the automated release notes label Mar 25, 2024
@peterzhuamazon peterzhuamazon marked this pull request as ready for review April 9, 2024 17:19
@peterzhuamazon peterzhuamazon added 4 - Doc review PR: Doc review in progress and removed On hold labels Apr 9, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Hi,

@hdhalter @Naarcha-AWS this is ready to review again.

Thanks.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

Thanks @Naarcha-AWS for the comment I have applied your suggestions.

Please review again

Thanks.

@Naarcha-AWS Naarcha-AWS added the backport 2.13 PR: Backport label for 2.13 label Apr 10, 2024
@Naarcha-AWS Naarcha-AWS merged commit 23445e8 into opensearch-project:main Apr 10, 2024
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2024
…lready deprecated (#6637)

* Update charts

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

* Update charts

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

---------

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 23445e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot pushed a commit that referenced this pull request Apr 10, 2024
@peterzhuamazon peterzhuamazon deleted the tweak-compatiblity-chart branch April 10, 2024 20:19
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete backport 2.13 PR: Backport label for 2.13
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OpenSearch docker image is based on EOSL amazon image
4 participants