Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update compatibility chart for OS support related changes #4980

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 7, 2023

Description

[NodeJS18 Upgrade] Update compatibility chart for NodeJS18 related changes

Issues Resolved

opensearch-project/opensearch-build#1563
opensearch-project/opensearch-build#3743
#4303

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon peterzhuamazon added upcoming release Don't merge until the version or feature is available installation Documentation for installing OpenSearch across various platforms v2.10.0 labels Sep 7, 2023
@peterzhuamazon peterzhuamazon self-assigned this Sep 7, 2023
@peterzhuamazon
Copy link
Member Author

We can hold this until the release of 2.10.0 @hdhalter .

Thanks.

@peterzhuamazon peterzhuamazon changed the title Update compatibility chart for NodeJS18 related changes [NodeJS18 Upgrade] Update compatibility chart for NodeJS18 related changes Sep 7, 2023
@hdhalter hdhalter added release-notes PR: Include this PR in the automated release notes 6 - Done but waiting to merge PR: The work is done and ready to merge and removed upcoming release Don't merge until the version or feature is available labels Sep 7, 2023
@bbarani
Copy link
Member

bbarani commented Sep 12, 2023

This is not targeted for 2.10.0 release.

Copy link
Member

@bbarani bbarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support the current OS list for 2.10.0 version but we need to add the deprecation notice for future version based on CentOS7 EOL date.

@peterzhuamazon peterzhuamazon removed 6 - Done but waiting to merge PR: The work is done and ready to merge v2.10.0 labels Sep 12, 2023
@peterzhuamazon peterzhuamazon marked this pull request as draft September 12, 2023 19:28
@peterzhuamazon peterzhuamazon changed the title [NodeJS18 Upgrade] Update compatibility chart for NodeJS18 related changes [WIP] Update compatibility chart for OS support related changes Sep 12, 2023
@Naarcha-AWS
Copy link
Collaborator

@peterzhuamazon: Do we still need update this compatibility chart?

@Naarcha-AWS
Copy link
Collaborator

@peterzhuamazon: Going to close this for now. Feel free to reopen it if we should merge this one.

@bbarani
Copy link
Member

bbarani commented Nov 15, 2023

@Naarcha-AWS A compatibility matrix for OpenSearch version would be needed when CentOS reaches EOL on June 30, 2024. We should communicate this change sooner to the community before sunsetting the CentOS support for OpenSearch versions.

@bbarani bbarani reopened this Nov 15, 2023
@Naarcha-AWS
Copy link
Collaborator

@bbarani: Should we just add a simple warning about the sun-setting of CentOS to the compatibility matrix page? Would that work until we can address the compatibility matrix?

@bbarani
Copy link
Member

bbarani commented Nov 15, 2023

@bbarani: Should we just add a simple warning about the sun-setting of CentOS to the compatibility matrix page? Would that work until we can address the compatibility matrix?

This might have wider impact for native plugins like K-NN. @peterzhuamazon Can you please list the impacts of sunsetting support for CentOS version? CC: @vamshin @navneet1v

@navneet1v
Copy link
Contributor

@peterzhuamazon , @bbarani with this PR, AL2 support will be removed. This can lead to big customer impact.

@bbarani
Copy link
Member

bbarani commented Jan 30, 2024

@navneet1v @peterzhuamazon can either of you open an issue related to CENTOS deprecation in Documentation repo and link this PR? We need to start putting out deprecation notice soon before we stop the support in upcoming version. CC: @vamshin

@peterzhuamazon
Copy link
Member Author

Close this PR.
The CentOS7 deprecation notice is here:
https://github.com/opensearch-project/opensearch-build/blob/2.12.0/release-notes/opensearch-release-notes-2.12.0.md#deprecation-notice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Documentation for installing OpenSearch across various platforms On hold release-notes PR: Include this PR in the automated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants